Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 7054008: Remove history dependency from content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.h
===================================================================
--- content/browser/tab_contents/tab_contents.h (revision 85923)
+++ content/browser/tab_contents/tab_contents.h (working copy)
@@ -39,10 +39,6 @@
class Rect;
}
-namespace history {
-class HistoryAddPageArgs;
-}
-
class Extension;
class LoadNotificationDetails;
class Profile;
@@ -480,15 +476,6 @@
virtual void SetBookmarkDragDelegate(
RenderViewHostDelegate::BookmarkDrag* bookmark_drag);
- // Updates history with the specified navigation. This is called by
- // OnMsgNavigate to update history state.
- void UpdateHistoryForNavigation(
- scoped_refptr<history::HistoryAddPageArgs> add_page_args);
-
- // Sends the page title to the history service. This is called when we receive
- // the page title and we know we want to update history.
- void UpdateHistoryPageTitle(const NavigationEntry& entry);
-
// Gets the zoom level for this tab.
double GetZoomLevel() const;
@@ -560,9 +547,6 @@
// TODO(brettw) TestTabContents shouldn't exist!
friend class TestTabContents;
- // Used to access the CreateHistoryAddPageArgs member function.
- friend class ExternalTabContainer;
-
// Add all the TabContentObservers.
void AddObservers();
@@ -637,13 +621,6 @@
void UpdateMaxPageIDIfNecessary(SiteInstance* site_instance,
RenderViewHost* rvh);
- // Returns the history::HistoryAddPageArgs to use for adding a page to
- // history.
- scoped_refptr<history::HistoryAddPageArgs> CreateHistoryAddPageArgs(
- const GURL& virtual_url,
- const NavigationController::LoadCommittedDetails& details,
- const ViewHostMsg_FrameNavigate_Params& params);
-
// Saves the given title to the navigation entry and does associated work. It
// will update history and the view for the new title, and also synthesize
// titles for file URLs that have none (so we require that the URL of the
@@ -840,12 +817,6 @@
// Data for current page -----------------------------------------------------
- // Whether we have a (non-empty) title for the current page.
- // Used to prevent subsequent title updates from affecting history. This
- // prevents some weirdness because some AJAXy apps use titles for status
- // messages.
- bool received_page_title_;
-
// When a navigation occurs, we record its contents MIME type. It can be
// used to check whether we can do something for some special contents.
std::string contents_mime_type_;

Powered by Google App Engine
This is Rietveld 408576698