Remove history dependency from content.

Remove history dependency from content.

BUG=76794
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86439

[jam, 2011-05-20 16:02:07]

The only change in behavior is in TabContents::DidNavigate.  Previously, we
would call UpdateHistoryForNavigation even if did_navigate is false.  Now, since
it's done by observing DidNavigateAnyFramePostCommit, did_navigate has to be
true.  This seemed fine to me (do we want to update the title if no navigation
happened?), since looking through the code that sets did_navigate to false, it
all seems for error/race conditions that we don't expect.

[brettw, 2011-05-24 16:20:45]

> looking through the code that sets did_navigate to false, it
> all seems for error/race conditions that we don't expect.

I think this statement is incorrect, but in studying the code I think the old
code was wrong to not add the data to history in these valid cases.

[brettw, 2011-05-24 16:21:03]

http://codereview.chromium.org/7054008/diff/5023/content/browser/tab_contents...
File content/browser/tab_contents/navigation_controller_unittest.cc (right):

http://codereview.chromium.org/7054008/diff/5023/content/browser/tab_contents...
content/browser/tab_contents/navigation_controller_unittest.cc:2079: class
NavigationControllerHistoryTest : public NavigationControllerTest {
It looks like you commented this out. Does this really fall under the TODO? Do
we have a testing story for this?

[jam, 2011-05-24 16:26:49]

http://codereview.chromium.org/7054008/diff/5023/content/browser/tab_contents...
File content/browser/tab_contents/navigation_controller_unittest.cc (right):

http://codereview.chromium.org/7054008/diff/5023/content/browser/tab_contents...
content/browser/tab_contents/navigation_controller_unittest.cc:2079: class
NavigationControllerHistoryTest : public NavigationControllerTest {
On 2011/05/24 16:21:03, brettw wrote:
> It looks like you commented this out. Does this really fall under the TODO? Do
> we have a testing story for this?

Not sure what you mean by testing story?  The tests are all commented out for 2
years.  If anyone starts looking into making them pass, they can move them to
chrome at the same time.

[brettw, 2011-05-24 16:49:50]

Sorry, misunderstood the test change. LGTM