Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7054002: Temporary fix until WebKit::initialize does this for us. (Closed)

Created:
9 years, 7 months ago by michaeln
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Temporary fix until WebKit::initialize does this for us. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86722

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/in_process_webkit/webkit_thread.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
michaeln
9 years, 7 months ago (2011-05-20 01:54:08 UTC) #1
michaeln
In the absence of a better answer for M13, should we do this now?
9 years, 7 months ago (2011-05-24 19:26:33 UTC) #2
jochen (gone - plz use gerrit)
On 2011/05/24 19:26:33, michaeln wrote: > In the absence of a better answer for M13, ...
9 years, 7 months ago (2011-05-24 19:36:22 UTC) #3
michaeln
@darin for content OWNERS review
9 years, 7 months ago (2011-05-24 21:57:16 UTC) #4
PhistucK
http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_webkit/webkit_thread.cc File content/browser/in_process_webkit/webkit_thread.cc (right): http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_webkit/webkit_thread.cc#newcode54 content/browser/in_process_webkit/webkit_thread.cc:54: // Exercise WebSecurityOrigin to get it's underlying statics initialized. ...
9 years, 7 months ago (2011-05-25 06:38:49 UTC) #5
michaeln
http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_webkit/webkit_thread.cc File content/browser/in_process_webkit/webkit_thread.cc (right): http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_webkit/webkit_thread.cc#newcode54 content/browser/in_process_webkit/webkit_thread.cc:54: // Exercise WebSecurityOrigin to get it's underlying statics initialized. ...
9 years, 7 months ago (2011-05-25 18:29:42 UTC) #6
darin (slow to review)
9 years, 7 months ago (2011-05-25 21:47:07 UTC) #7
LGTM

On Wed, May 25, 2011 at 11:29 AM, <michaeln@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_w...
> File content/browser/in_process_webkit/webkit_thread.cc (right):
>
>
>
http://codereview.chromium.org/7054002/diff/2001/content/browser/in_process_w...
> content/browser/in_process_webkit/webkit_thread.cc:54: // Exercise
> WebSecurityOrigin to get it's underlying statics initialized.
> On 2011/05/25 06:38:49, PhistucK wrote:
>
>> s/it's/its
>>
>
> Done.
>
>
> http://codereview.chromium.org/7054002/
>

Powered by Google App Engine
This is Rietveld 408576698