Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Try to fix trybot failures and address torne's comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index dd3f0cdc16a224f825ec32ffd3ddc24530c94298..07481044d5a597818a719b4debfdc94c45037602 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -17,8 +17,6 @@
#include "chrome/browser/download/download_util.h"
#include "chrome/browser/extensions/extension_info_map.h"
#include "chrome/browser/notifications/desktop_notification_service.h"
-#include "chrome/browser/notifications/desktop_notification_service_factory.h"
-#include "chrome/browser/notifications/notifications_prefs_cache.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
@@ -285,14 +283,12 @@ RenderMessageFilter::RenderMessageFilter(
resource_context_(profile->GetResourceContext()),
extensions_request_context_(profile->GetRequestContextForExtensions()),
render_widget_helper_(render_widget_helper),
- notification_prefs_(
- DesktopNotificationServiceFactory::GetForProfile(profile)->
- prefs_cache()),
incognito_(profile->IsOffTheRecord()),
webkit_context_(profile->GetWebKitContext()),
render_process_id_(render_process_id) {
DCHECK(request_context_);
+ profile_->GetPrefs();
render_widget_helper_->Init(render_process_id_, resource_dispatcher_host_);
}
@@ -623,7 +619,8 @@ void RenderMessageFilter::OnCheckNotificationPermission(
// Fall back to the regular notification preferences, which works on an
// origin basis.
- *result = notification_prefs_->HasPermission(source_url.GetOrigin());
+ *result = DesktopNotificationService::HasPermission(profile_,
+ source_url.GetOrigin());
}
void RenderMessageFilter::OnAllocateSharedMemoryBuffer(

Powered by Google App Engine
This is Rietveld 408576698