chrome/chrome_browser.gypi - Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Try to fix trybot failures and address torne's comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.h ('K') | « chrome/browser/task_manager/task_manager_resource_providers.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index af68e1c3f8bd9ef9dc9d4e9bc6dfe93c98017153..d78b514cc024193da5a81169df1ab8edd1c80cad 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -791,6 +791,7 @@

'browser/defaults.h',

'browser/desktop_notification_handler.cc',

'browser/desktop_notification_handler.h',

+ 'browser/desktop_notification_handler_stub.cc',

'browser/diagnostics/diagnostics_main.cc',

'browser/diagnostics/diagnostics_main.h',

'browser/diagnostics/diagnostics_model.cc',

@@ -1463,6 +1464,7 @@

'browser/notifications/notification_object_proxy.h',

'browser/notifications/notification_options_menu_model.cc',

'browser/notifications/notification_options_menu_model.h',

+ 'browser/notifications/notification_stubs.cc',

'browser/notifications/notification_ui_manager.cc',

'browser/notifications/notification_ui_manager.h',

'browser/notifications/notifications_prefs_cache.cc',

@@ -2118,6 +2120,8 @@

'browser/tabs/tab_strip_selection_model.h',

'browser/task_manager/task_manager.cc',

'browser/task_manager/task_manager.h',

+ 'browser/task_manager/task_manager_notification_resource_provider.cc',

+ 'browser/task_manager/task_manager_notification_resource_provider_stub.cc',

'browser/task_manager/task_manager_resource_providers.cc',

'browser/task_manager/task_manager_resource_providers.h',

'browser/themes/browser_theme_pack.cc',

@@ -4468,6 +4472,20 @@

['exclude', '^browser/ui/views/file_manager_dialogs.cc'],

]}

+ ['enable_desktop_notifications==0', {

+ 'sources/': [

+ ['exclude', '^browser/desktop_notification_handler.cc'],

+ ['exclude', '^browser/notifications/'],

+ ['include', '^browser/notifications/notification_stubs.cc'],

+ ['exclude', '^browser/task_manager/task_manager_notification_resource_provider.cc'],

+ ]

+ }, { # enable_desktop_notifications==0

+ 'sources!': [

+ 'browser/desktop_notification_handler_stub.cc',

+ 'browser/notifications/notification_stubs.cc',

+ 'browser/task_manager/task_manager_notification_resource_provider_stub.cc',

+ ]

+ }],

{