Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/background_contents_service.cc

Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background_contents_service.cc
diff --git a/chrome/browser/background_contents_service.cc b/chrome/browser/background_contents_service.cc
index d6de00f7a15c5d643a0375c7327abf38f04ddb33..9ed820dcd2d0a2b93daf163213a4084f3e7c7018 100644
--- a/chrome/browser/background_contents_service.cc
+++ b/chrome/browser/background_contents_service.cc
@@ -100,14 +100,12 @@ void ShowBalloon(const Extension* extension, Profile* profile) {
extension->is_hosted_app() ? IDS_BACKGROUND_CRASHED_APP_BALLOON_MESSAGE :
IDS_BACKGROUND_CRASHED_EXTENSION_BALLOON_MESSAGE,
UTF8ToUTF16(extension->name()));
- string16 content_url = DesktopNotificationService::CreateDataUrl(
+ DesktopNotificationService::ShowBalloon(
+ extension->url(),
extension->GetIconURL(Extension::EXTENSION_ICON_SMALLISH,
ExtensionIconSet::MATCH_BIGGER),
- string16(), message, WebKit::WebTextDirectionDefault);
- Notification notification(
- extension->url(), GURL(content_url), string16(), string16(),
- new CrashNotificationDelegate(profile, extension));
- g_browser_process->notification_ui_manager()->Add(notification, profile);
+ string16(), message, new CrashNotificationDelegate(profile, extension),
+ profile);
}
}

Powered by Google App Engine
This is Rietveld 408576698