chrome/browser/notifications/notification_ui_manager.cc - Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager.cc

Issue 7053041: Add a Create method to DesktopNotificationHandler and stubs for the notification objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/notifications/notification_ui_manager.h ('k') | chrome/browser/task_manager/task_manager.cc » ('j') | content/browser/renderer_host/render_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_ui_manager.cc

diff --git a/chrome/browser/notifications/notification_ui_manager.cc b/chrome/browser/notifications/notification_ui_manager.cc

index 56c90f2dad1eab018b906f2c67a7cd562bec747d..8a46c1ecf2c3b1877a7541c58c0b64364928cc96 100644

--- a/chrome/browser/notifications/notification_ui_manager.cc

+++ b/chrome/browser/notifications/notification_ui_manager.cc

@@ -67,7 +67,12 @@ NotificationUIManager::~NotificationUIManager() {

// static

NotificationUIManager* NotificationUIManager::Create(PrefService* local_state) {

- BalloonCollection* balloons = BalloonCollection::Create();

+ return Create(local_state, BalloonCollection::Create());

+// static

+NotificationUIManager* NotificationUIManager::Create(

+ PrefService* local_state, BalloonCollection* balloons) {

John Gregg 2011/06/06 17:12:27 nit: i think the style preference here is one per

Satish 2011/06/06 20:36:43 Done.

NotificationUIManager* instance = new NotificationUIManager(local_state);

instance->Initialize(balloons);

balloons->set_space_change_listener(instance);