Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/mjsunit/regress/regress-1170.js

Issue 7053035: Fix a number of tests that incorrectly used assertUnreachable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/regress/regress-1160.js ('k') | test/mjsunit/regress/regress-1172-bis.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 24 matching lines...) Expand all
35 eval("with({}) { eval('var a = 2') }"); 35 eval("with({}) { eval('var a = 2') }");
36 assertEquals(2, setter_value); 36 assertEquals(2, setter_value);
37 assertFalse(this.hasOwnProperty("a")); 37 assertFalse(this.hasOwnProperty("a"));
38 38
39 // Function declarations are treated specially to match Safari. We do 39 // Function declarations are treated specially to match Safari. We do
40 // not call setters for them. 40 // not call setters for them.
41 eval("function a() {}"); 41 eval("function a() {}");
42 assertTrue(this.hasOwnProperty("a")); 42 assertTrue(this.hasOwnProperty("a"));
43 43
44 __proto__.__defineSetter__("b", function(v) { assertUnreachable(); }); 44 __proto__.__defineSetter__("b", function(v) { assertUnreachable(); });
45 var exception = false;
45 try { 46 try {
46 eval("const b = 23"); 47 eval("const b = 23");
47 assertUnreachable();
48 } catch(e) { 48 } catch(e) {
49 exception = true;
49 assertTrue(/TypeError/.test(e)); 50 assertTrue(/TypeError/.test(e));
50 } 51 }
52 assertTrue(exception);
53
54 exception = false;
51 try { 55 try {
52 eval("with({}) { eval('const b = 23') }"); 56 eval("with({}) { eval('const b = 23') }");
53 assertUnreachable();
54 } catch(e) { 57 } catch(e) {
58 exception = true;
55 assertTrue(/TypeError/.test(e)); 59 assertTrue(/TypeError/.test(e));
56 } 60 }
61 assertTrue(exception);
57 62
58 __proto__.__defineSetter__("c", function(v) { throw 42; }); 63 __proto__.__defineSetter__("c", function(v) { throw 42; });
64 exception = false;
59 try { 65 try {
60 eval("var c = 1"); 66 eval("var c = 1");
61 assertUnreachable();
62 } catch(e) { 67 } catch(e) {
68 exception = true;
63 assertEquals(42, e); 69 assertEquals(42, e);
64 assertFalse(this.hasOwnProperty("c")); 70 assertFalse(this.hasOwnProperty("c"));
65 } 71 }
72 assertTrue(exception);
OLDNEW
« no previous file with comments | « test/mjsunit/regress/regress-1160.js ('k') | test/mjsunit/regress/regress-1172-bis.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698