Fix a number of tests that incorrectly used assertUnreachable.

test/mjsunit/object-define-property.js

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 12 matching lines @@
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Tests the object.defineProperty method - ES 15.2.3.6
 
 // Flags: --allow-natives-syntax
 
 // Check that an exception is thrown when null is passed as object.
+var exception = false;
 try {
   Object.defineProperty(null, null, null);
-  assertTrue(false);
 } catch (e) {
+  exception = true;
   assertTrue(/called on non-object/.test(e));
 }
+assertTrue(exception);
 
 // Check that an exception is thrown when undefined is passed as object.
+exception = false;
 try {
   Object.defineProperty(undefined, undefined, undefined);
-  assertTrue(false);
 } catch (e) {
+  exception = true;
   assertTrue(/called on non-object/.test(e));
 }
+assertTrue(exception);
 
 // Check that an exception is thrown when non-object is passed as object.
+exception = false;
 try {
   Object.defineProperty(0, "foo", undefined);
-  assertTrue(false);
 } catch (e) {
+  exception = true;
   assertTrue(/called on non-object/.test(e));
 }
+assertTrue(exception);
 
 // Object.
 var obj1 = {};
 
 // Values.
 var val1 = 0;
 var val2 = 0;
 var val3 = 0;
 
 function setter1() {val1++; }
@@ skipping 623 matching lines @@
 
 // Make sure that we can't overwrite +0 with -0 and vice versa.
 var descMinusZero = {value: -0, configurable: false};
 var descPlusZero = {value: +0, configurable: false};
 
 Object.defineProperty(obj5, 'minuszero', descMinusZero);
 
 // Make sure we can redefine with -0.
 Object.defineProperty(obj5, 'minuszero', descMinusZero);
 
+exception = false;
 try {
   Object.defineProperty(obj5, 'minuszero', descPlusZero);
-  assertUnreachable();
 } catch (e) {
+  exception = true;
   assertTrue(/Cannot redefine property/.test(e));
 }
+assertTrue(exception);
 
 
 Object.defineProperty(obj5, 'pluszero', descPlusZero);
 
 // Make sure we can redefine with +0.
 Object.defineProperty(obj5, 'pluszero', descPlusZero);
 
+exception = false;
 try {
   Object.defineProperty(obj5, 'pluszero', descMinusZero);
-  assertUnreachable();
 } catch (e) {
+  exception = true;
   assertTrue(/Cannot redefine property/.test(e));
 }
+assertTrue(exception);
 
 
 var obj6 = {};
 obj6[1] = 'foo';
 obj6[2] = 'bar';
 obj6[3] = '42';
 obj6[4] = '43';
 obj6[5] = '44';
 
 var descElement = { value: 'foobar' };
@@ skipping 27 matching lines @@
 try {
   Object.defineProperty(obj6, '2', descElement);
   desc = Object.getOwnPropertyDescriptor(obj6, '2');
   assertEquals(desc.value, 'foobar');
 } catch (e) {
   assertUnreachable();
 }
 
 // Ensure that we can't change the descriptor of a
 // non configurable property.
+exception = false;
 try {
   var descAccessor = { get: function() { return 0; } };
   Object.defineProperty(obj6, '2', descAccessor);
-  assertUnreachable();
 } catch (e) {
+  exception = true;
   assertTrue(/Cannot redefine property/.test(e));
 }
+assertTrue(exception);
 
 Object.defineProperty(obj6, '2', descElementNonWritable);
 desc = Object.getOwnPropertyDescriptor(obj6, '2');
 assertEquals(desc.value, 'foofoo');
 assertFalse(desc.writable);
 assertTrue(desc.enumerable);
 assertFalse(desc.configurable);
 
 Object.defineProperty(obj6, '3', descElementNonWritable);
 desc = Object.getOwnPropertyDescriptor(obj6, '3');
@@ skipping 70 matching lines @@
 try {
   Object.defineProperty(arr, '2', descElement);
   desc = Object.getOwnPropertyDescriptor(arr, '2');
   assertEquals(desc.value, 'foobar');
 } catch (e) {
   assertUnreachable();
 }
 
 // Ensure that we can't change the descriptor of a
 // non configurable property.
+exception = false;
 try {
   var descAccessor = { get: function() { return 0; } };
   Object.defineProperty(arr, '2', descAccessor);
-  assertUnreachable();
 } catch (e) {
+  exception = true;
   assertTrue(/Cannot redefine property/.test(e));
 }
+assertTrue(exception);
 
 Object.defineProperty(arr, '2', descElementNonWritable);
 desc = Object.getOwnPropertyDescriptor(arr, '2');
 assertEquals(desc.value, 'foofoo');
 assertFalse(desc.writable);
 assertTrue(desc.enumerable);
 assertFalse(desc.configurable);
 
 Object.defineProperty(arr, '3', descElementNonWritable);
 desc = Object.getOwnPropertyDescriptor(arr, '3');
@@ skipping 146 matching lines @@
   { enumerable : false, configurable : false },
   { get: getter1, set: setter1, enumerable : false, configurable : false });
 
 // redefine of set only property with generic descriptor
 o = {};
 Object.defineProperty(o, 'p',
   { set : setter1, enumerable: true, configurable: true });
 testDefineProperty(o, 'p',
   { enumerable : false, configurable : false },
   { get: undefined, set: setter1, enumerable : false, configurable : false });