Issue 7053033: Base: cleanup for base.dll. Move base_switches back to the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7053033: Base: cleanup for base.dll. Move base_switches back to the (Closed)

Created:
9 years, 7 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Base: cleanup for base.dll. Move base_switches back to the main project. BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86899

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -27 lines)			Patch
M	base/base.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	base/base.gypi	View	3 chunks	+13 lines, -12 lines	0 comments	Download
M	base/base_switches.h	View	1 chunk	+13 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

rvargas (doing something else)

The difference with the code that you already reviewed is that now base depends on ...

9 years, 7 months ago (2011-05-26 01:17:53 UTC) #1

LGTM