Issue 7053029: Leak fix in FileSystemOperationUnitTest.

Issue 7053029: Leak fix in FileSystemOperationUnitTest. (Closed)

Created:
9 years, 7 months ago by kinuko

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Leak fix in FileSystemOperationUnitTest. BUG=83944 TEST=valgrind bots green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86792

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/file_system_operation_unittest.cc	View	1	3 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

Will remove suppressions and run trybots. (For now I need to afk)

9 years, 7 months ago (2011-05-25 23:48:57 UTC) #1

oshima

http://codereview.chromium.org/7053029/diff/1001/webkit/fileapi/file_system_operation_unittest.cc File webkit/fileapi/file_system_operation_unittest.cc (right): http://codereview.chromium.org/7053029/diff/1001/webkit/fileapi/file_system_operation_unittest.cc#newcode96 webkit/fileapi/file_system_operation_unittest.cc:96: EXPECT_FALSE(registered_client_); Any reason not deleting here? (deletion order matters?) ...

9 years, 7 months ago (2011-05-26 01:17:07 UTC) #2

kinuko

Will wait and make sure until trybots go green. http://codereview.chromium.org/7053029/diff/1001/webkit/fileapi/file_system_operation_unittest.cc File webkit/fileapi/file_system_operation_unittest.cc (right): http://codereview.chromium.org/7053029/diff/1001/webkit/fileapi/file_system_operation_unittest.cc#newcode96 webkit/fileapi/file_system_operation_unittest.cc:96: ...

9 years, 7 months ago (2011-05-26 02:19:25 UTC) #3

LGTM

Expand Messages | Collapse Messages