Issue 7053019: Fix the failed AssertionTest and CheckFalseTest for touch build

Issue 7053019: Fix the failed AssertionTest and CheckFalseTest for touch build (Closed)

Created:
9 years, 7 months ago by Yufeng Shen (Slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, commit-bot: I haz the power, sadrul

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix the failed AssertionTest and CheckFalseTest for touch build set the expected errors accordingly with touch build BUG= TEST=AssertionTest.* & CheckFalseTest.* pass on touch build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86693

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing some comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/common/logging_chrome_uitest.cc	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM with the nits http://codereview.chromium.org/7053019/diff/1/chrome/common/logging_chrome_uitest.cc File chrome/common/logging_chrome_uitest.cc (right): http://codereview.chromium.org/7053019/diff/1/chrome/common/logging_chrome_uitest.cc#newcode77 chrome/common/logging_chrome_uitest.cc:77: // Touch build will start ...

9 years, 7 months ago (2011-05-25 19:05:23 UTC) #2

Yufeng Shen (Slow to review)

http://codereview.chromium.org/7053019/diff/1/chrome/common/logging_chrome_uitest.cc File chrome/common/logging_chrome_uitest.cc (right): http://codereview.chromium.org/7053019/diff/1/chrome/common/logging_chrome_uitest.cc#newcode77 chrome/common/logging_chrome_uitest.cc:77: // Touch build will start an extra renderer process ...

9 years, 7 months ago (2011-05-25 19:13:07 UTC) #3

Change committed as 86693

Expand Messages | Collapse Messages