Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 7053018: Rebase stdout files, add new command_string capturing group. (Closed)

Created:
9 years, 7 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com, bradnelson
Visibility:
Public.

Description

Rebase stdout files, add new command_string capturing group. Committed: http://code.google.com/p/gyp/source/detail?r=926

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -152 lines) Patch
M test/variables/commands/commands-repeated.gyp.stdout View 20 chunks +64 lines, -64 lines 0 comments Download
M test/variables/commands/commands.gyp.stdout View 10 chunks +38 lines, -38 lines 0 comments Download
test/variables/commands/commands.gyp.ignore-env.stdout View 10 chunks +38 lines, -38 lines 0 comments Download
M test/variables/filelist/filelist.gyp.stdout View 1 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
9 years, 7 months ago (2011-05-25 18:08:59 UTC) #1
bradn
LGTM
9 years, 7 months ago (2011-05-25 18:11:54 UTC) #2
Nico
How do I run gyp tests locally by the way? :-)
9 years, 7 months ago (2011-05-25 18:12:21 UTC) #3
Mark Mentovai
Looks like test/variables/filelist/gyptest-filelist.py failed too.
9 years, 7 months ago (2011-05-25 18:12:24 UTC) #4
Mark Mentovai
gyptest.py in the GYP top level. The bots run buildbot/buildbot_run.py.
9 years, 7 months ago (2011-05-25 18:14:05 UTC) #5
Mark Mentovai
9 years, 7 months ago (2011-05-25 18:17:24 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698