Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: content/browser/plugin_process_host.cc

Issue 7053008: Revert 86532 - Revert 86517 - Don't terminate plugin processes from the browser during browser sh... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/child_process_launcher.cc ('k') | content/plugin/plugin_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_process_host.cc
===================================================================
--- content/browser/plugin_process_host.cc (revision 86552)
+++ content/browser/plugin_process_host.cc (working copy)
@@ -221,6 +221,12 @@
#endif
cmd_line);
+ // The plugin needs to be shutdown gracefully, i.e. NP_Shutdown needs to be
+ // called on the plugin. The plugin process exits when it receives the
+ // OnChannelError notification indicating that the browser plugin channel has
+ // been destroyed.
+ SetTerminateChildOnShutdown(false);
+
content::GetContentClient()->browser()->PluginProcessHostCreated(this);
AddFilter(new ResolveProxyMsgHelper(NULL));
« no previous file with comments | « content/browser/child_process_launcher.cc ('k') | content/plugin/plugin_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698