Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7053008: Revert 86532 - Revert 86517 - Don't terminate plugin processes from the browser during browser sh... (Closed)

Created:
9 years, 7 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Revert 86532 - Revert 86517 - Don't terminate plugin processes from the browser during browser shutdown. This is to allow the plugins to shutdown gracefully, i.e. NP_Shutdown gets called. To ensure that we handle the case of a hung plugin, we handle the OnChannelError notification in the IPC message filter implementation in the plugin process and post a delayed task to kill the process. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48178 BUG=48178 Review URL: http://codereview.chromium.org/6992006 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/7065048 TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M content/browser/browser_child_process_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/child_process_launcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/child_process_launcher.cc View 5 chunks +19 lines, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/plugin/plugin_channel.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
9 years, 7 months ago (2011-05-25 02:12:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698