We need this work-around for file:/// URIs as

We need this work-around for file:/// URIs as
 createFromDatabaseIdentifier() returns empty origin urls for them.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86563

[ericu, 2011-05-25 02:38:42]

LGTM

http://codereview.chromium.org/7053007/diff/3001/webkit/database/database_uti...
File webkit/database/database_util_unittest.cc (right):

http://codereview.chromium.org/7053007/diff/3001/webkit/database/database_uti...
webkit/database/database_util_unittest.cc:50: }
How about a test for an http origin, while you're in here?

[michaeln, 2011-05-25 03:23:36]

http://codereview.chromium.org/7053007/diff/3001/webkit/database/database_uti...
File webkit/database/database_util_unittest.cc (right):

http://codereview.chromium.org/7053007/diff/3001/webkit/database/database_uti...
webkit/database/database_util_unittest.cc:50: }
On 2011/05/25 02:38:42, ericu wrote:
> How about a test for an http origin, while you're in here?

Done.

[ericu, 2011-05-25 03:29:51]

Thanks!

[abarth-chromium, 2011-11-17 03:12:24]

This patch looks very wrong.  I'm not sure what problem this patch is trying to
solve, but WebKit will shortly stop producing "file__0" as the storage
identifier for unique origins generated from file URLs.

[abarth-chromium, 2011-11-17 03:24:37]

Some more context:

All unique origins ought to be the same.  The fact that file origins that became
unique remembered that they used to be file origins is a bug that we're going to
fix shortly.  The premise of this patch is wrong.  If a URL gives rise to a
unique origin, there's no way to go back to the URL.