Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 7052001: Rolling Skia DEPS to r1385 (and modifying affected gyp file) (Closed)

Created:
9 years, 7 months ago by epoger
Modified:
9 years, 7 months ago
CC:
chromium-reviews, reed1, Nico
Visibility:
Public.

Description

Rolling Skia DEPS to r1385 (and modifying affected gyp file) Corresponding "control" changelist (for comparison of trybot results) is http://codereview.chromium.org/7047016 . I await results from the trybots. It looks like a Skia change between r1365 and r1385 requires a change to skia/skia.gyp, because a previous DEPS roll try resulted in the following error in http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/236/steps/compile/logs/stdio Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
epoger
Adding Nico since this might slop over into tomorrow, when he is Skia Gardener.
9 years, 7 months ago (2011-05-19 20:09:21 UTC) #1
epoger
So far this one seems to be going OK, but there are still a few ...
9 years, 7 months ago (2011-05-19 21:31:27 UTC) #2
vandebo (ex-Chrome)
It LGTM. I'm going to try the commit button and then push it if that ...
9 years, 7 months ago (2011-05-19 21:36:07 UTC) #3
epoger
<sigh> on several counts. 1. Steve pushed the "commit" checkbox, but the commit never happened. ...
9 years, 7 months ago (2011-05-20 14:07:50 UTC) #4
bsalomon
As of skia r_1390 the following pretty trivial diff is needed to roll skia: Index: ...
9 years, 7 months ago (2011-05-20 14:18:07 UTC) #5
vandebo (ex-Chrome)
Oops, I forgot to circle back to this. I will commit this CL as is ...
9 years, 7 months ago (2011-05-20 16:11:07 UTC) #6
Nico
On Fri, May 20, 2011 at 9:11 AM, <vandebo@chromium.org> wrote: > Oops, I forgot to ...
9 years, 7 months ago (2011-05-20 16:21:44 UTC) #7
vandebo (ex-Chrome)
9 years, 7 months ago (2011-05-20 16:25:58 UTC) #8
On 2011/05/20 16:21:44, Nico wrote:
> On Fri, May 20, 2011 at 9:11 AM,  <mailto:vandebo@chromium.org> wrote:
> > Oops, I forgot to circle back to this. &nbsp;I will commit this CL as is and
then
> > let Nico do the gardening from there.
> 
> Cool, thanks! I was just starting to look at landing this CL :-)
> 
> Let me know when you're done.

It's in, just watching the tree.

Powered by Google App Engine
This is Rietveld 408576698