Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4653)

Unified Diff: chrome/browser/resources/print_preview.js

Issue 7051026: Print Preview: Changing error message when initiator tab closes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments, rebasing. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview.js
diff --git a/chrome/browser/resources/print_preview.js b/chrome/browser/resources/print_preview.js
index b9b935f8406d619802c192c6899e5381c9d9f776..9bc3731f709260e2d504da5ab2f1cc35a6328143 100644
--- a/chrome/browser/resources/print_preview.js
+++ b/chrome/browser/resources/print_preview.js
@@ -47,7 +47,7 @@ function onLoad() {
$('cancel-button').addEventListener('click', handleCancelButtonClick);
if (!checkCompatiblePluginExists()) {
- displayErrorMessage(localStrings.getString('noPlugin'));
+ displayErrorMessage(localStrings.getString('noPlugin'), false);
$('mainview').parentElement.removeChild($('dummy-viewer'));
return;
}
@@ -101,8 +101,10 @@ function showSystemDialog() {
* @param {string} initiatorTabURL The URL of the initiator tab.
*/
function onInitiatorTabClosed(initiatorTabURL) {
- displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
- initiatorTabURL));
+ $('reopen-page').addEventListener('click', function() {
+ window.location = initiatorTabURL;
+ });
+ displayErrorMessage(localStrings.getString('initiatorTabClosed'), true);
}
/**
@@ -383,14 +385,21 @@ function setColor(color) {
/**
* Display an error message in the center of the preview area.
- * @param (string) errorMessage The error message to be displayed.
+ * @param {string} errorMessage The error message to be displayed.
+ * @param {boolean} showButton Indivates whether the "Reopen the page" button
+ * should be displayed.
*/
-function displayErrorMessage(errorMessage) {
+function displayErrorMessage(errorMessage, showButton) {
isPreviewStillLoading = false;
$('dancing-dots').classList.remove('invisible');
$('dancing-dots-text').classList.add('hidden');
$('error-text').innerHTML = errorMessage;
$('error-text').classList.remove('hidden');
+ if (showButton)
+ $('reopen-page').classList.remove('hidden');
+ else
+ $('reopen-page').classList.add('hidden');
+
setControlsDisabled(true);
var pdfViewer = $('pdf-viewer');
@@ -403,7 +412,7 @@ function displayErrorMessage(errorMessage) {
* Called from PrintPreviewMessageHandler::OnPrintPreviewFailed().
*/
function printPreviewFailed() {
- displayErrorMessage(localStrings.getString('previewFailed'));
+ displayErrorMessage(localStrings.getString('previewFailed'), false);
}
/**
« no previous file with comments | « chrome/browser/resources/print_preview.html ('k') | chrome/browser/ui/webui/print_preview_ui_html_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698