Print Preview: Changing error message when initiator tab closes.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 29 matching lines @@
 
 /**
  * Window onload handler, sets up the page and starts print preview by getting
  * the printer list.
  */
 function onLoad() {
   $('system-dialog-link').addEventListener('click', showSystemDialog);
   $('cancel-button').addEventListener('click', handleCancelButtonClick);
 
   if (!checkCompatiblePluginExists()) {
-    displayErrorMessage(localStrings.getString('noPlugin'));
+    displayErrorMessage(localStrings.getString('noPlugin'), false);
     $('mainview').parentElement.removeChild($('dummy-viewer'));
     return;
   }
   $('mainview').parentElement.removeChild($('dummy-viewer'));
 
   $('printer-list').disabled = true;
   $('print-button').disabled = true;
   $('print-button').addEventListener('click', printFile);
   $('all-pages').addEventListener('click', onPageSelectionMayHaveChanged);
   $('copies').addEventListener('input', copiesFieldChanged);
@@ skipping 33 matching lines @@
 function showSystemDialog() {
   chrome.send('showSystemDialog');
 }
 
 /**
  * Disables the controls which need the initiator tab to generate preview
  * data. This function is called when the initiator tab is closed.
  * @param {string} initiatorTabURL The URL of the initiator tab.
  */
 function onInitiatorTabClosed(initiatorTabURL) {
-  displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
-                                              initiatorTabURL));
+  $('reopen-page').addEventListener('click', function() {

[Lei Zhang, 2011/05/23 07:07:04]

Show this go in onload()?

[dpapad, 2011/05/23 16:05:31]

It cant go in onload() because |initiatorTabURL| is not known at that time. This
function is directly called from c++ code. Also I prefer not introducing another
global variable. Adding the listener right before showing the button seems ok to
me.

+      window.location = initiatorTabURL;
+  });
+  displayErrorMessage(localStrings.getString('initiatorTabClosed'), true);
 }
 
 /**
  * Gets the selected printer capabilities and updates the controls accordingly.
  */
 function updateControlsWithSelectedPrinterCapabilities() {
   var printerList = $('printer-list');
   var selectedIndex = printerList.selectedIndex;
   if (selectedIndex < 0)
     return;
@@ skipping 260 matching lines @@
 function setColor(color) {
   var pdfViewer = $('pdf-viewer');
   if (!pdfViewer) {
     return;
   }
   pdfViewer.grayscale(!color);
 }
 
 /**
  * Display an error message in the center of the preview area.
  * @param (string) errorMessage The error message to be displayed.

[Lei Zhang, 2011/05/23 07:07:04]

update comment.

[dpapad, 2011/05/23 16:05:31]

Done.

  */
-function displayErrorMessage(errorMessage) {
+function displayErrorMessage(errorMessage, showButton) {
   isPreviewStillLoading = false;
   $('dancing-dots').classList.remove('invisible');
   $('dancing-dots-text').classList.add('hidden');
   $('error-text').innerHTML = errorMessage;
   $('error-text').classList.remove('hidden');
+  if (showButton)
+    $('reopen-page').classList.remove('hidden');

[Lei Zhang, 2011/05/23 07:07:04]

can we ever get into a situation where displayErrorMessage() gets called once
with |showButton| = true and then again with |showButton| = false? If yes, then
add a else case to hide the button.

[dpapad, 2011/05/23 16:05:31]

I cant think of such a scenario, but I will add the else statement just to be
safe.

   setControlsDisabled(true);
 
   var pdfViewer = $('pdf-viewer');
   if (pdfViewer)
     $('mainview').removeChild(pdfViewer);
 }
 
 /**
  * Display an error message when print preview fails.
  * Called from PrintPreviewMessageHandler::OnPrintPreviewFailed().
  */
 function printPreviewFailed() {
-  displayErrorMessage(localStrings.getString('previewFailed'));
+  displayErrorMessage(localStrings.getString('previewFailed'), false);
 }
 
 /**
  * Called when the PDF plugin loads its document.
  */
 function onPDFLoad() {
   if (isLandscape())
     $('pdf-viewer').fitToWidth();
   else
     $('pdf-viewer').fitToHeight();
@@ skipping 475 matching lines @@
     copiesField.value = 1;
   else {
     var newValue = getCopies() + sign * 1;
     if (newValue < copiesField.min || newValue > copiesField.max)
       return;
     copiesField.value = newValue;
   }
   copiesFieldChanged();
 }