gtk: Split DownloadShelfContextMenuGtk out to its own header file.

gtk: Split DownloadShelfContextMenuGtk out to its own header file.

This moves the implementation of DownloadShelfContextMenuGtk from download_item_gtk.cc to download_shelf_context_menu_gtk.* 

BUG=28978
TEST=None

R=evan@chromium.org,rdsmith@chromium.org,asanka@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86193

[tfarina, 2011-05-20 01:28:37]

Please, take a look.

[Randy Smith (Not in Mondays), 2011-05-20 13:47:17]

Core download portion of download UI reviews delegated to Asanka.

[asanka, 2011-05-20 21:23:52]

LGTM, with a few nits.

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
File chrome/browser/ui/gtk/download/download_item_gtk.cc (left):

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
chrome/browser/ui/gtk/download/download_item_gtk.cc:153: // DownloadItemGtk
-------------------------------------------------------------
Nit: We don't need this section header comment here anymore.

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
File chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h (right):

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h:24: // the
button press event that caused this menu to be created.
Can this comment be cleaned up while you are here?  I don't think the
constructor does what this says anymore.

[Randy Smith (Not in Mondays), 2011-05-20 22:11:13]

On 2011/05/20 21:23:52, asanka wrote:
> LGTM, with a few nits.
> 
>
http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
> File chrome/browser/ui/gtk/download/download_item_gtk.cc (left):
> 
>
http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
> chrome/browser/ui/gtk/download/download_item_gtk.cc:153: // DownloadItemGtk
> -------------------------------------------------------------
> Nit: We don't need this section header comment here anymore.
> 
>
http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
> File chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h (right):
> 
>
http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
> chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h:24: // the
> button press event that caused this menu to be created.
> Can this comment be cleaned up while you are here?  I don't think the
> constructor does what this says anymore.

Rubber-stamp LGTM.

[tfarina, 2011-05-20 22:15:47]

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
File chrome/browser/ui/gtk/download/download_item_gtk.cc (left):

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
chrome/browser/ui/gtk/download/download_item_gtk.cc:153: // DownloadItemGtk
-------------------------------------------------------------
On 2011/05/20 21:23:52, asanka wrote:
> Nit: We don't need this section header comment here anymore.

Done.

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
File chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h (right):

http://codereview.chromium.org/7051021/diff/7001/chrome/browser/ui/gtk/downlo...
chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h:24: // the
button press event that caused this menu to be created.
On 2011/05/20 21:23:52, asanka wrote:
> Can this comment be cleaned up while you are here?  I don't think the
> constructor does what this says anymore.

Removed.