Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 7051014: Globally replace <(library) with static_library (Closed)

Created:
9 years, 7 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, vrk (LEFT CHROMIUM), dmaclach+watch_chromium.org, annacc, ajwong+watch_chromium.org, kinuko+watch, ncarter (slow), idana, jam, apatrick_chromium, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), michaeln, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, sjl, garykac+watch_chromium.org, acolwell GONE FROM CHROMIUM, lambroslambrou+watch_chromium.org
Visibility:
Public.

Description

Globally replace <(library) with static_library We provided <(library) as a variable to support a peculiar build configuration on Linux. We no longer support that build configuration, so we can simplify this code to no longer use a variable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -160 lines) Patch
M app/app_base.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M base/allocator/allocator.gyp View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 5 chunks +5 lines, -5 lines 0 comments Download
M base/base.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M base/third_party/dynamic_annotations/dynamic_annotations.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M breakpad/breakpad.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M breakpad/breakpad_handler.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M breakpad/breakpad_sender.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/policy/cloud_policy_codegen.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/common_constants.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/default_plugin.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mac/third_party/xz/xz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl.gypi View 2 chunks +1 line, -4 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -1 line 0 comments Download
M courgette/courgette.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/crypto.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/jingle.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M media/media.gyp View 6 chunks +6 lines, -6 lines 0 comments Download
M net/net.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/proto/chromotocol.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/proto/trace.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 7 chunks +7 lines, -7 lines 0 comments Download
M sandbox/sandbox.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M sdch/sdch.gyp View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/gtest.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
third_party/bspatch/bspatch.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/cld/cld.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/expat/expat.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/iaccessible2/iaccessible2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/iccjpeg/iccjpeg.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/isimpledom/isimpledom.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/libwebp.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lzma_sdk/lzma_sdk.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mach_override/mach_override.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/modp_b64.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/openmax.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/qcms/qcms.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/snappy/snappy.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/undoview/undoview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/zlib.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl.gyp View 1 chunk +1 line, -1 line 0 comments Download
ui/gfx/surface/surface.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_gfx.gypi View 1 chunk +1 line, -1 line 0 comments Download
ui/ui_views.gypi View 1 chunk +1 line, -1 line 0 comments Download
M views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/webkit_appcache.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/database/webkit_database.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/gpu/webkit_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/webkit_quota.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
the only interesting change is nacl.gyp
9 years, 7 months ago (2011-05-19 22:37:43 UTC) #1
jam
9 years, 7 months ago (2011-05-19 23:02:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698