Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/code-stubs.h

Issue 7050039: Revert 8122 (stub call asserts) while test failures are investigated. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
===================================================================
--- src/code-stubs.h (revision 8124)
+++ src/code-stubs.h (working copy)
@@ -75,7 +75,7 @@
V(KeyedLoadExternalArray) \
V(KeyedStoreExternalArray) \
V(DebuggerStatement) \
- V(StringDictionaryLookup)
+ V(StringDictionaryNegativeLookup)
// List of code stubs only used on ARM platforms.
#ifdef V8_TARGET_ARCH_ARM
@@ -144,13 +144,6 @@
virtual ~CodeStub() {}
- // See comment above, where Instanceof is defined.
- virtual bool CompilingCallsToThisStubIsGCSafe() {
- return MajorKey() <= Instanceof;
- }
-
- virtual bool SometimesSetsUpAFrame() { return true; }
-
protected:
static const int kMajorBits = 6;
static const int kMinorBits = kBitsPerInt - kSmiTagSize - kMajorBits;
@@ -207,6 +200,9 @@
MajorKeyBits::encode(MajorKey());
}
+ // See comment above, where Instanceof is defined.
+ bool AllowsStubCalls() { return MajorKey() <= Instanceof; }
+
class MajorKeyBits: public BitField<uint32_t, 0, kMajorBits> {};
class MinorKeyBits: public BitField<uint32_t, kMajorBits, kMinorBits> {};
@@ -579,11 +575,6 @@
void Generate(MacroAssembler* masm);
void SaveDoubles() { save_doubles_ = true; }
- // The version of this stub that doesn't save doubles is generated ahead of
- // time, so it's OK to call it from other stubs that can't cope with GC during
- // their code generation.
- virtual bool CompilingCallsToThisStubIsGCSafe() { return !save_doubles_; }
-
private:
void GenerateCore(MacroAssembler* masm,
Label* throw_normal_exception,
« no previous file with comments | « src/builtins.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698