Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7050039: Revert 8122 (stub call asserts) while test failures are investigated. (Closed)

Created:
9 years, 6 months ago by Erik Corry
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert 8122 (stub call asserts) while test failures are investigated. Committed: http://code.google.com/p/v8/source/detail?r=8125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1933 lines, -2305 lines) Patch
M include/v8.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/arm/builtins-arm.cc View 11 chunks +494 lines, -515 lines 0 comments Download
M src/arm/code-stubs-arm.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 12 chunks +47 lines, -66 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +37 lines, -39 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/ic-arm.cc View 2 chunks +17 lines, -19 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 6 chunks +14 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 12 chunks +9 lines, -37 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 4 chunks +42 lines, -46 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs.h View 4 chunks +4 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/frames.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 13 chunks +437 lines, -459 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 8 chunks +37 lines, -47 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +42 lines, -43 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +20 lines, -24 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 5 chunks +13 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 13 chunks +10 lines, -37 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +42 lines, -47 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +0 lines, -57 lines 0 comments Download
M src/x64/builtins-x64.cc View 10 chunks +474 lines, -495 lines 0 comments Download
M src/x64/code-stubs-x64.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +21 lines, -29 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +49 lines, -50 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +19 lines, -21 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 6 chunks +13 lines, -10 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 13 chunks +13 lines, -37 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +42 lines, -47 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 6 months ago (2011-05-31 15:18:34 UTC) #1
Kevin Millikin (Chromium)
9 years, 6 months ago (2011-05-31 15:19:16 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698