chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 7050031: dom-ui settings: Stop observing an existing BrowserDataRemover before creating a new one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 7050031: dom-ui settings: Stop observing an existing BrowserDataRemover before creating a new one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

===================================================================

--- chrome/browser/ui/webui/options/clear_browser_data_handler.cc (revision 84869)

+++ chrome/browser/ui/webui/options/clear_browser_data_handler.cc (working copy)

@@ -125,6 +125,12 @@

web_ui_->CallJavascriptFunction("ClearBrowserDataOverlay.setClearingState",

state);

+ // If we are still observing a previous data remover, we need to stop

+ // observing.

+ if (remover_) {

+ remover_->RemoveObserver(this);

+ }

James Hawkins 2011/05/20 21:09:37 nit: No need for braces.

csilv 2011/05/20 21:11:54 Done.

// BrowsingDataRemover deletes itself when done.

remover_ = new BrowsingDataRemover(profile,

static_cast<BrowsingDataRemover::TimePeriod>(period_selected),

« no previous file with comments | « no previous file | no next file » | no next file with comments »