Issue 7050031: dom-ui settings: Stop observing an existing BrowserDataRemover before creating a new one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7050031: dom-ui settings: Stop observing an existing BrowserDataRemover before creating a new one. (Closed)

Created:
9 years, 7 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, Randy Smith (Not in Mondays)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui settings: Stop observing an existing BrowserDataRemover before creating a new one. BUG=81916 TEST=Follow repro setps in bug report, verify that crash no longer occurs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86146

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : Style tweaks (cosmetic) #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/options/clear_browser_data_handler.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM http://codereview.chromium.org/7050031/diff/2001/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): http://codereview.chromium.org/7050031/diff/2001/chrome/browser/ui/webui/options/clear_browser_data_handler.cc#newcode132 chrome/browser/ui/webui/options/clear_browser_data_handler.cc:132: } nit: No need for braces.

9 years, 7 months ago (2011-05-20 21:09:37 UTC) #2

csilv

9 years, 7 months ago (2011-05-20 21:11:54 UTC) #3

http://codereview.chromium.org/7050031/diff/2001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

http://codereview.chromium.org/7050031/diff/2001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:132: }
On 2011/05/20 21:09:37, James Hawkins wrote:
> nit: No need for braces.

Done.

Expand Messages | Collapse Messages