Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 7050022: Comment on WARN_UNUSED_RESULT about how to defeat it. (Closed)

Created:
9 years, 7 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Comment on WARN_UNUSED_RESULT about how to defeat it. Comment change only. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86022

Patch Set 1 #

Total comments: 1

Patch Set 2 : Mark change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/compiler_specific.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Hess - ex-Googler
I was impressed by how long it took me to figure out when I needed ...
9 years, 7 months ago (2011-05-19 21:11:18 UTC) #1
sky
LGTM
9 years, 7 months ago (2011-05-19 22:23:35 UTC) #2
Mark Mentovai
LG otherwise. Or LGTM to satisfy stupid PRESUBMIT. http://codereview.chromium.org/7050022/diff/1/base/compiler_specific.h File base/compiler_specific.h (right): http://codereview.chromium.org/7050022/diff/1/base/compiler_specific.h#newcode114 base/compiler_specific.h:114: // ...
9 years, 7 months ago (2011-05-19 23:17:13 UTC) #3
Scott Hess - ex-Googler
Commenting are hard. On 2011/05/19 23:17:13, Mark Mentovai wrote: > LG otherwise. > > Or ...
9 years, 7 months ago (2011-05-19 23:19:42 UTC) #4
Mark Mentovai
That’s better! LGTM.
9 years, 7 months ago (2011-05-19 23:32:06 UTC) #5
Mark Mentovai
It kind of sucks that Chrome allays separates_words_with_underscores_in_filenames, but this file adheres to a different ...
9 years, 7 months ago (2011-05-19 23:33:52 UTC) #6
commit-bot: I haz the power
9 years, 7 months ago (2011-05-20 00:48:37 UTC) #7
Change committed as 86022

Powered by Google App Engine
This is Rietveld 408576698