Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 7049032: Make URLPattern::OverlapsWith handle wildcards better by expanding them to explicit schemes. (Closed)

Created:
9 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make URLPattern::OverlapsWith handle wildcards better by expanding them to explicit schemes. BUG=70126 TEST=no R=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M chrome/common/extensions/url_pattern.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/url_pattern.cc View 2 chunks +33 lines, -8 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mihai Parparita -not on Chrome
9 years, 7 months ago (2011-05-20 00:30:37 UTC) #1
asargent_no_longer_on_chrome
9 years, 7 months ago (2011-05-20 18:52:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698