Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 7049028: [Sync] Speed up Javascript node operations (Closed)

Created:
9 years, 7 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, arv (Not doing code reviews), Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

[Sync] Speed up Javascript node operations Changed getNodeById to getNodesById and added getChildNodeIds. This avoids having to loop through a node's children in Javascript, which is slow. This speeds up expanding the "Autofill" node in the sync node browser by 40-50% (with ~2700 elements). With a debug Chromium, time spent retrieving the nodes goes from 30s to 18s, and with a release Chromium time it goes from 2.9s to 1.3s. This will also speed up search, which will be implemented shortly. Add timer logs to some sync node browser operations. Fix docs for some functions called from Javascript. BUG=76812 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -75 lines) Patch
M chrome/browser/resources/sync_internals/chrome_sync.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/sync_node_browser.js View 3 chunks +32 lines, -9 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 1 chunk +15 lines, -13 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 3 chunks +70 lines, -19 lines 0 comments Download
M chrome/browser/sync/engine/syncapi_unittest.cc View 3 chunks +144 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+zea for review
9 years, 7 months ago (2011-05-19 23:50:40 UTC) #1
Nicolas Zea
9 years, 7 months ago (2011-05-20 01:15:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698