Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 7049021: Adjust PPAPI tests so they can also be run in the NaCl build using PyAuto. (Closed)

Created:
9 years, 7 months ago by cstefansen
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M ppapi/tests/nacl.scons View 1 1 chunk +53 lines, -12 lines 0 comments Download
M ppapi/tests/test_case.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_case.nmf View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/testing_instance.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cstefansen
Addendum: what remains is to transition the test jig itself to PostMessage a forthcoming CL ...
9 years, 7 months ago (2011-05-19 22:46:57 UTC) #1
cstefansen
brettw@ appears to be incommunicado; piman@ would you mind reviewing this? On 2011/05/19 22:46:57, cstefansen ...
9 years, 7 months ago (2011-05-23 20:38:52 UTC) #2
piman
LGTM. You'll need a rebase.
9 years, 7 months ago (2011-05-23 20:43:12 UTC) #3
cstefansen
9 years, 7 months ago (2011-05-23 22:44:39 UTC) #4
Thanks. Committed revision 86356.

On 2011/05/23 20:43:12, piman wrote:
> LGTM. You'll need a rebase.

Powered by Google App Engine
This is Rietveld 408576698