Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 7049012: Cause the 'enable-nacl' flag to be locked with enabling the NaCl plugin. (Closed)

Created:
9 years, 7 months ago by der Springer
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cause the 'enable-nacl' flag to be locked with enabling the NaCl plugin. Note that this code only affects users (developers) who turn on the NaCl flag, and it's temporary code until NaCL is turned on by default. BUG=81010 TEST=about_flags_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86346

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use const for "enable-nacl" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 3 chunks +18 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
der Springer
9 years, 7 months ago (2011-05-19 17:38:06 UTC) #1
dmichael (off chromium)
LGTM, assuming you get a clean Mac try (looks like it's not yours). But I'll ...
9 years, 7 months ago (2011-05-19 20:54:14 UTC) #2
der Springer
Adding a few folks who were cc'd on the bug.
9 years, 7 months ago (2011-05-19 21:57:09 UTC) #3
jam
lgtm http://codereview.chromium.org/7049012/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/7049012/diff/1/chrome/browser/about_flags.cc#newcode684 chrome/browser/about_flags.cc:684: if (internal_name == "enable-nacl") { is there no ...
9 years, 7 months ago (2011-05-19 22:56:46 UTC) #4
der Springer
9 years, 7 months ago (2011-05-20 17:47:15 UTC) #5
http://codereview.chromium.org/7049012/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7049012/diff/1/chrome/browser/about_flags.cc#n...
chrome/browser/about_flags.cc:684: if (internal_name == "enable-nacl") {
On 2011/05/19 22:56:46, John Abd-El-Malek wrote:
> is there no constant for this?  kEnableNaCl?  

Done.

Powered by Google App Engine
This is Rietveld 408576698