chrome/browser/renderer_host/render_process_host_browsertest.cc - Issue 7049010: Finish removing url_constants from content/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/renderer_host/render_process_host_browsertest.cc

Issue 7049010: Finish removing url_constants from content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/tab_contents/render_view_host_manager_unittest.cc » ('j') | chrome/browser/tab_contents/render_view_host_manager_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
	jam 2011/05/19 17:21:16 i don't think we want to move the whole test file, i don't think we want to move the whole test file, since only one of the tests is related to dev tools. the others belong in the content layer, since we'll want to test that stuff with the multi-proc test shell when it exists. can you create render_process_host_browsertest.h and reuse the base test class in a new file in chrome that has the devtools test?
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "chrome/browser/debugger/devtools_manager.h"	6 #include "chrome/browser/debugger/devtools_manager.h"

7 #include "chrome/browser/ui/browser.h"	7 #include "chrome/browser/ui/browser.h"

8 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"	8 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

9 #include "chrome/common/chrome_switches.h"	9 #include "chrome/common/chrome_switches.h"

10 #include "chrome/common/url_constants.h"	10 #include "chrome/common/url_constants.h"

11 #include "chrome/test/in_process_browser_test.h"	11 #include "chrome/test/in_process_browser_test.h"

(...skipping 242 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
254 tab_count++;	254 tab_count++;

255 host_count++;	255 host_count++;

256 EXPECT_EQ(tab_count, browser()->tab_count());	256 EXPECT_EQ(tab_count, browser()->tab_count());

257 tab1 = browser()->GetTabContentsAt(tab_count - 1);	257 tab1 = browser()->GetTabContentsAt(tab_count - 1);

258 rph3 = tab1->GetRenderProcessHost();	258 rph3 = tab1->GetRenderProcessHost();

259 EXPECT_EQ(tab1->GetURL(), bookmarks);	259 EXPECT_EQ(tab1->GetURL(), bookmarks);

260 EXPECT_EQ(host_count, RenderProcessHostCount());	260 EXPECT_EQ(host_count, RenderProcessHostCount());

261 EXPECT_NE(rph1, rph3);	261 EXPECT_NE(rph1, rph3);

262 EXPECT_NE(rph2, rph3);	262 EXPECT_NE(rph2, rph3);

263 }	263 }

OLD	NEW