Issue 7049005: Refactor TraceInlining method of hydrogen so it works correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7049005: Refactor TraceInlining method of hydrogen so it works correctly. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Refactor TraceInlining method of hydrogen so it works correctly. Fix TraceInline. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7961

Patch Set 2 : fix compilation #

Total comments: 1

Patch Set 3 : adopt Kevin's suggestion that makes it less bad. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -28 lines)			Patch
	M	src/hydrogen.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/hydrogen.cc	View	1 2	10 chunks	+23 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/7049005/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7049005/diff/2001/src/hydrogen.cc#newcode4060 src/hydrogen.cc:4060: CompilationInfo* outer_info = info(); Move this up a few ...

9 years, 7 months ago (2011-05-19 11:24:03 UTC) #2

Yes.  LGTM.