Normalize chrome://foo/ trailing slashes, ChromeURLHostEquals comparison, RIP dead consts.

chrome/browser/extensions/extension_install_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 51 matching lines @@
 const int kIconSize = 69;
 
 // Shows the application install animation on the new tab page for the app
 // with |app_id|. If a NTP already exists on the active |browser|, this will
 // select that tab and show the animation there. Otherwise, it will create
 // a new NTP.
 void ShowAppInstalledAnimation(Browser* browser, const std::string& app_id) {
   // Select an already open NTP, if there is one. Existing NTPs will
   // automatically show the install animation for any new apps.
   for (int i = 0; i < browser->tab_count(); ++i) {
-    TabContents* tab_contents = browser->GetTabContentsAt(i);
-    GURL url = tab_contents->GetURL();
-    if (StartsWithASCII(url.spec(), chrome::kChromeUINewTabURL, false)) {
+    GURL url = browser->GetTabContentsAt(i)->GetURL();
+    if (url.SchemeIs(chrome::kChromeUIScheme) &&
+        LowerCaseEqualsASCII(url.host(), chrome::kChromeUINewTabHost)) {
       browser->ActivateTabAt(i, false);
       return;
     }
   }
 
   // If there isn't an NTP, open one and pass it the ID of the installed app.
   std::string url = base::StringPrintf(
-      "%s/#app-id=%s", chrome::kChromeUINewTabURL, app_id.c_str());
+      "%s#app-id=%s", chrome::kChromeUINewTabURL, app_id.c_str());
   browser->AddSelectedTabWithURL(GURL(url), PageTransition::TYPED);
 }
 
 }  // namespace
 
 ExtensionInstallUI::ExtensionInstallUI(Profile* profile)
     : profile_(profile),
       ui_loop_(MessageLoop::current()),
       previous_using_native_theme_(false),
       extension_(NULL),
@@ skipping 182 matching lines @@
 
 InfoBarDelegate* ExtensionInstallUI::GetNewThemeInstalledInfoBarDelegate(
     TabContents* tab_contents,
     const Extension* new_theme,
     const std::string& previous_theme_id,
     bool previous_using_native_theme) {
   return new ThemeInstalledInfoBarDelegate(tab_contents, new_theme,
                                            previous_theme_id,
                                            previous_using_native_theme);
 }