Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/test/data/extensions/api_test/webrequest/events/test.html

Issue 7048010: Fix onBeforeSendHeaders regression: we were sending {name: name} for every (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_webrequest_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/webrequest/events/test.html
diff --git a/chrome/test/data/extensions/api_test/webrequest/events/test.html b/chrome/test/data/extensions/api_test/webrequest/events/test.html
index b286f01a4e0d71129916f82c5aae056e8d8a3fff..0fca7887722d0190f07b2a9f80f42049ed2e0308 100644
--- a/chrome/test/data/extensions/api_test/webrequest/events/test.html
+++ b/chrome/test/data/extensions/api_test/webrequest/events/test.html
@@ -104,6 +104,16 @@ function checkExpectations() {
eventsCaptured();
}
+// Simple check to see that we have a User-Agent header, and that it contains
+// an expected value. This is a basic check that the request headers are valid.
+function checkUserAgent(headers) {
+ for (var i in headers) {
+ if (headers[i].name.toLowerCase() == "user-agent")
+ return headers[i].value.toLowerCase().indexOf("chrome") != -1;
+ }
+ return false;
+}
+
function captureEvent(name, details) {
// Ignore system-level requests like safebrowsing updates and favicon fetches
// since they are unpredictable.
@@ -123,7 +133,7 @@ function captureEvent(name, details) {
delete details.requestId;
delete details.timeStamp;
if (details.requestHeaders) {
- details.requestHeadersExist = true;
+ details.requestHeadersValid = checkUserAgent(details.requestHeaders);
delete details.requestHeaders;
}
if (details.responseHeaders) {
@@ -263,7 +273,7 @@ runTests([
event: "onBeforeSendHeaders",
details: {
url: URL_HTTP_SIMPLE_LOAD_REDIRECT,
- requestHeadersExist: true
+ requestHeadersValid: true
}
},
{ label: "onRequestSent-1",
@@ -271,7 +281,7 @@ runTests([
details: {
url: URL_HTTP_SIMPLE_LOAD_REDIRECT,
ip: "127.0.0.1",
- requestHeadersExist: true
+ requestHeadersValid: true
}
},
{ label: "onBeforeRedirect",
@@ -297,7 +307,7 @@ runTests([
event: "onBeforeSendHeaders",
details: {
url: URL_HTTP_SIMPLE_LOAD,
- requestHeadersExist: true
+ requestHeadersValid: true
}
},
{ label: "onRequestSent-2",
@@ -305,7 +315,7 @@ runTests([
details: {
url: URL_HTTP_SIMPLE_LOAD,
ip: "127.0.0.1",
- requestHeadersExist: true
+ requestHeadersValid: true
}
},
{ label: "onResponseStarted",
« no previous file with comments | « chrome/browser/extensions/extension_webrequest_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698