[Mac] Fix "No drag (+) cursor displayed when dragging link over BMB"

[Mac] Fix "No drag (+) cursor displayed when dragging link over BMB"

Return NSDragOperationCopy for BookmarBarButton drags and NSDragOperationMove
for other drag types. Updated unit tests to set a BookmarkBarButton as the
mock |draggingSource| for bookmark bar dragging tests and made the tests
check for the expected drag operation type.

BUG=83228
TEST=Drag a link from a page and hover over the BMB. Cursor should be a (+).
Drag a bookmark button. Cursor shouldn't be a (+).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86696

[mrossetti, 2011-05-19 20:14:27]

LGTM

[commit-bot: I haz the power, 2011-05-20 19:25:44]

Try job failure for 7048009-1 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[Alexei Svitkine (slow), 2011-05-21 02:04:43]

On Fri, May 20, 2011 at 3:25 PM,  <commit-bot@chromium.org> wrote:
> Try job failure for 7048009-1 on mac:
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
>
> http://codereview.chromium.org/7048009/
>

Looks like the test doesn't use a BookmarkButton as the drag source,
but expects NSDragOperationMove to be returned.

I'll revise the patch to update the tests and also make sure that they
check for the differences in operation between a drag of a
BookmarkButton vs. other drags.

-Alexei

[Alexei Svitkine (slow), 2011-05-24 14:55:08]

Here's an updated patch with changes to the unit tests.

[asvitkine_google, 2011-05-25 15:39:44]

Ping!

Can either of you take a look at my updated patch? Thanks!

On Tue, May 24, 2011 at 10:55 AM,  <asvitkine@chromium.org> wrote:
> Here's an updated patch with changes to the unit tests.
>
> http://codereview.chromium.org/7048009/
>

[maf, 2011-05-25 18:47:22]

Looking now.


Maf

On Wed, May 25, 2011 at 8:38 AM, Alexei Svitkine <asvitkine@google.com>wrote:

> Ping!
>
> Can either of you take a look at my updated patch? Thanks!
>
> On Tue, May 24, 2011 at 10:55 AM,  <asvitkine@chromium.org> wrote:
> > Here's an updated patch with changes to the unit tests.
> >
> > http://codereview.chromium.org/7048009/
> >
>

[mafv, 2011-05-25 18:50:35]

http://codereview.chromium.org/7048009/diff/5001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm (right):

http://codereview.chromium.org/7048009/diff/5001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm:66: -
(void)setDraggingSource:(id)dragginSource {
Typo "dragginSource".  Please fix throughout.

[Alexei Svitkine (slow), 2011-05-25 19:14:12]

http://codereview.chromium.org/7048009/diff/5001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm (right):

http://codereview.chromium.org/7048009/diff/5001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm:66: -
(void)setDraggingSource:(id)dragginSource {
On 2011/05/25 18:50:36, mafv wrote:
> Typo "dragginSource".  Please fix throughout.

Done, thanks! (Typo was just in this parameter).

[mafv, 2011-05-25 19:30:38]

LGTM

[commit-bot: I haz the power, 2011-05-25 20:45:16]

Change committed as 86696