src/ia32/macro-assembler-ia32.cc - Issue 7048003: Improve bit tests on IA32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 7048003: Improve bit tests on IA32. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

===================================================================

--- src/ia32/macro-assembler-ia32.cc (revision 7947)

+++ src/ia32/macro-assembler-ia32.cc (working copy)

@@ -73,7 +73,9 @@

shr(addr, Page::kRegionSizeLog2);

// Set dirty mark for region.

Søren Thygesen Gjesse 2011/05/23 08:26:17 Please add a comment here why loading to a registe

- bts(Operand(object, Page::kDirtyFlagOffset), addr);

+ mov(scratch, Operand(object, Page::kDirtyFlagOffset));

+ bts(Operand(scratch), addr);

+ mov(Operand(object, Page::kDirtyFlagOffset), scratch);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »