Issue 7046110: Make TrialDirMixIn so it can be used stand alone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046110: Make TrialDirMixIn so it can be used stand alone. (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Make TrialDirMixIn so it can be used stand alone. This will be used in commit queue tests. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88986

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	tests/trial_dir.py	View		2 chunks	+13 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 6 months ago (2011-06-14 06:22:09 UTC) #2

LGTM.

http://codereview.chromium.org/7046110/diff/1/tests/trial_dir.py
File tests/trial_dir.py (right):

http://codereview.chromium.org/7046110/diff/1/tests/trial_dir.py#newcode69
tests/trial_dir.py:69: """Stand alone mixin."""
This comment doesn't tell me anything about what this is, and worse, I think
these three words are self-contradictory. I'd probably just delete it.

Expand Messages | Collapse Messages