Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: chrome/browser/chromeos/upgrade_detector_chromeos.h

Issue 7046096: Refactor UpgradeDetector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix clang bots Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/upgrade_detector_chromeos.h
diff --git a/chrome/browser/chromeos/upgrade_detector_chromeos.h b/chrome/browser/chromeos/upgrade_detector_chromeos.h
new file mode 100644
index 0000000000000000000000000000000000000000..09f2f701b5ba3521d4942a755862ef9d439dcaf9
--- /dev/null
+++ b/chrome/browser/chromeos/upgrade_detector_chromeos.h
@@ -0,0 +1,40 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_UPGRADE_DETECTOR_CHROMEOS_H_
+#define CHROME_BROWSER_CHROMEOS_UPGRADE_DETECTOR_CHROMEOS_H_
+#pragma once
+
+#include "base/timer.h"
+#include "chrome/browser/chromeos/cros/update_library.h"
+#include "chrome/browser/upgrade_detector.h"
+
+template <typename T> struct DefaultSingletonTraits;
+
+class UpgradeDetectorChromeos : public UpgradeDetector,
+ public chromeos::UpdateLibrary::Observer {
+ public:
+ virtual ~UpgradeDetectorChromeos();
+
+ static UpgradeDetectorChromeos* GetInstance();
+
+ private:
+ friend struct DefaultSingletonTraits<UpgradeDetectorChromeos>;
+
+ UpgradeDetectorChromeos();
+
+ // chromeos::UpdateLibrary::Observer implementation.
+ virtual void UpdateStatusChanged(chromeos::UpdateLibrary* library);
Finnur 2011/06/12 12:07:43 Does this need to be virtual?
xiyuan 2011/06/12 21:02:07 Yes because this is from UpdateLibrary::Observer i
Finnur 2011/06/12 22:19:21 Oh, then you should probably add OVERRIDE? On 201
xiyuan 2011/06/12 22:31:24 Even for pure virtual function?
Finnur 2011/06/12 22:38:29 Hmm... Good question. I don't know. You can probab
+
+ // The function that sends out a notification (after a certain time has
+ // elapsed) that lets the rest of the UI know we should start notifying the
+ // user that a new version is available.
+ void NotifyOnUpgrade();
+
+ // After we detect an upgrade we start a recurring timer to see if enough time
+ // has passed and we should start notifying the user.
+ base::RepeatingTimer<UpgradeDetectorChromeos> upgrade_notification_timer_;
+};
+
+#endif // CHROME_BROWSER_CHROMEOS_UPGRADE_DETECTOR_CHROMEOS_H_

Powered by Google App Engine
This is Rietveld 408576698