Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: ppapi/tests/test_url_loader.cc

Issue 7046091: Fix problems with PPB_URLLoader_Impl and PPAPITests.URLLoader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_url_loader.cc
===================================================================
--- ppapi/tests/test_url_loader.cc (revision 88908)
+++ ppapi/tests/test_url_loader.cc (working copy)
@@ -11,11 +11,13 @@
#include "ppapi/c/dev/ppb_file_io_dev.h"
#include "ppapi/c/dev/ppb_file_io_trusted_dev.h"
#include "ppapi/c/dev/ppb_testing_dev.h"
+#include "ppapi/c/dev/ppb_url_util_dev.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/ppb_url_loader.h"
#include "ppapi/cpp/dev/file_io_dev.h"
#include "ppapi/cpp/dev/file_ref_dev.h"
#include "ppapi/cpp/dev/file_system_dev.h"
+#include "ppapi/cpp/dev/url_util_dev.h"
#include "ppapi/cpp/instance.h"
#include "ppapi/cpp/module.h"
#include "ppapi/cpp/url_loader.h"
@@ -271,9 +273,16 @@
}
std::string TestURLLoader::TestCrossOriginRequest() {
+ // Get the document URL and use it to construct a URL that will be
+ // considered cross-origin by the WebKit access control code, and yet be
+ // reachable by the test server.
+ PP_URLComponents_Dev components;
+ pp::Var document_url = GetDocumentURL(instance_, &components);
+ std::string cross_origin_url = document_url.AsString();
+ cross_origin_url.replace("127.0.0.1", "localhost");
+
pp::URLRequestInfo request(instance_);
- // Create a URL that will be considered to be a different origin.
- request.SetURL("http://127.0.0.1/test_url_loader_data/hello.txt");
+ request.SetURL(cross_origin_url);
request.SetAllowCrossOriginRequests(true);
TestCompletionCallback callback(instance_->pp_instance());
@@ -284,7 +293,7 @@
rv = callback.WaitForResult();
// We expect success since we allowed a cross-origin request.
- if (rv == PP_ERROR_NOACCESS)
+ if (rv != PP_OK)
return ReportError("URLLoader::Open()", rv);
PASS();
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppb_url_loader_impl.cc » ('j') | webkit/plugins/ppapi/ppb_url_loader_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698