Fix problems with PPB_URLLoader_Impl and PPAPITests.URLLoader.

webkit/plugins/ppapi/ppb_url_loader_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_url_loader_impl.h"
 
 #include "base/logging.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/ppb_url_loader.h"
@@ skipping 457 matching lines @@
 }
 
 void PPB_URLLoader_Impl::didFinishLoading(WebURLLoader* loader,
                                           double finish_time) {
   done_status_ = PP_OK;
   RunCallback(done_status_);
 }
 
 void PPB_URLLoader_Impl::didFail(WebURLLoader* loader,
                                  const WebURLError& error) {
-  // TODO(darin): Provide more detailed error information.
-  done_status_ = PP_ERROR_FAILED;
+  // If a URL load fails, return PP_ERROR_NOACCESS instead of the more generic
+  // PP_ERROR_FAILED. There is no simple concept of error codes in the
+  // underlying WebKit loader framework.
+  done_status_ = PP_ERROR_NOACCESS;

[darin (slow to review), 2011/06/11 05:13:12]

Well, the error codes actually are defined by Chromium.  In particular, most
error codes come from the underlying WebURLLoader implementation that lives in
Chromium.  I'm sure we can interpret those here.

Perhaps you sometimes see error codes that do not have domain set to
net::kErrorDomain?  In that case, maybe it makes sense to map those to
PP_ERROR_NOACCESS?

Please also note that for error codes used by WebCore that are not generated by
the network stack, WebCore::FrameLoaderClient methods are called to get access
to them:  e.g., cancelledError, blockedError, cannotShowMIMETypeError, etc.

   RunCallback(done_status_);
 }
 
 int32_t PPB_URLLoader_Impl::ValidateCallback(PP_CompletionCallback callback) {
   // We only support non-blocking calls.
   if (!callback.func)
     return PP_ERROR_BADARGUMENT;
 
   if (pending_callback_.get() && !pending_callback_->completed())
     return PP_ERROR_INPROGRESS;
@@ skipping 83 matching lines @@
 bool PPB_URLLoader_Impl::RecordDownloadProgress() const {
   return request_info_ && request_info_->record_download_progress();
 }
 
 bool PPB_URLLoader_Impl::RecordUploadProgress() const {
   return request_info_ && request_info_->record_upload_progress();
 }
 
 }  // namespace ppapi
 }  // namespace webkit