Fix problems with PPB_URLLoader_Impl and PPAPITests.URLLoader.

ppapi/tests/test_url_loader.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_url_loader.h"
 
 #include <stdio.h>
 #include <string.h>
 #include <string>
 
@@ skipping 31 matching lines @@
 
 void TestURLLoader::RunTest() {
   RUN_TEST(BasicGET);
   RUN_TEST(BasicPOST);
   RUN_TEST(CompoundBodyPOST);
   RUN_TEST(EmptyDataPOST);
   RUN_TEST(BinaryDataPOST);
   RUN_TEST(CustomRequestHeader);
   RUN_TEST(IgnoresBogusContentLength);
   RUN_TEST(SameOriginRestriction);
-  RUN_TEST(CrossOriginRequest);
+  // TODO(bbudge) Find out how to create a request that URL loaders would
+  // consider cross-origin, but that can be served by test server.
+  //RUN_TEST(CrossOriginRequest);
   RUN_TEST(StreamToFile);
   RUN_TEST(AuditURLRedirect);
   RUN_TEST(AbortCalls);
 }
 
 std::string TestURLLoader::ReadEntireFile(pp::FileIO_Dev* file_io,
                                           std::string* data) {
   TestCompletionCallback callback(instance_->pp_instance());
   char buf[256];
   int64_t offset = 0;
@@ skipping 214 matching lines @@
   request.SetAllowCrossOriginRequests(true);
 
   TestCompletionCallback callback(instance_->pp_instance());
 
   pp::URLLoader loader(*instance_);
   int32_t rv = loader.Open(request, callback);
   if (rv == PP_ERROR_WOULDBLOCK)
     rv = callback.WaitForResult();
 
   // We expect success since we allowed a cross-origin request.
-  if (rv == PP_ERROR_NOACCESS)
+  if (rv != PP_OK)
     return ReportError("URLLoader::Open()", rv);
 
   PASS();
 }
 
 // This test should cause a redirect and ensure that the loader runs
 // the callback, rather than following the redirect.
 std::string TestURLLoader::TestAuditURLRedirect() {
   pp::URLRequestInfo request(instance_);
   // This path will cause the server to return a 301 redirect.
@@ skipping 76 matching lines @@
 
   // TODO(viettrungluu): More abort tests (but add basic tests first).
   // Also test that Close() aborts properly. crbug.com/69457
 
   PASS();
 }
 
 // TODO(viettrungluu): Add tests for FollowRedirect,
 // Get{Upload,Download}Progress, Close (including abort tests if applicable).
 // TODO(darin): Add a test for GrantUniversalAccess.