Rolled NaCl DEPS to 5586

Rolled NaCl DEPS to 5586


BUG=None
TEST=Trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88578

[Matt Ball, 2011-06-09 19:20:21]

Linux trybot looks good, and Windows and Mac trybots are looking good so far.

[Matt Ball, 2011-06-09 19:57:45]

On 2011/06/09 19:20:21, Matt Ball wrote:
> Linux trybot looks good, and Windows and Mac trybots are looking good so far.

Windows and Mac bots looks good now.

[Matt Ball, 2011-06-09 20:00:38]

On 2011/06/09 19:57:45, Matt Ball wrote:
> On 2011/06/09 19:20:21, Matt Ball wrote:
> > Linux trybot looks good, and Windows and Mac trybots are looking good so
far.
> 
> Windows and Mac bots looks good now.


Looks like Noel is on vacation and Dave is in Germany.  Adding ncbray...

[Nick Bray, 2011-06-09 20:06:32]

LGTM

http://codereview.chromium.org/7046079/diff/1/DEPS
File DEPS (right):

http://codereview.chromium.org/7046079/diff/1/DEPS#newcode15
DEPS:15: "nacl_tools_revision": "5580",
You don't need to bump nacl_tools_revision, but it doesn't hurt.  Why you didn't
bump it to 5586 confuses me.

[Matt Ball, 2011-06-09 20:11:33]

http://codereview.chromium.org/7046079/diff/1/DEPS
File DEPS (right):

http://codereview.chromium.org/7046079/diff/1/DEPS#newcode15
DEPS:15: "nacl_tools_revision": "5580",
On 2011/06/09 20:06:33, Nick Bray wrote:
> You don't need to bump nacl_tools_revision, but it doesn't hurt.  Why you
didn't
> bump it to 5586 confuses me.

I bumped it to the same tools version as in the r5586 NaCl DEPS file.  That
seemed to be the safest version, since it most closely matches NaCl's
environment.

[noelallen_use_chromium, 2011-06-09 20:48:05]

LGTM

http://codereview.chromium.org/7046079/diff/1/DEPS
File DEPS (right):

http://codereview.chromium.org/7046079/diff/1/DEPS#newcode15
DEPS:15: "nacl_tools_revision": "5580",
Sounds right to me.

On 2011/06/09 20:11:33, Matt Ball wrote:
> On 2011/06/09 20:06:33, Nick Bray wrote:
> > You don't need to bump nacl_tools_revision, but it doesn't hurt.  Why you
> didn't
> > bump it to 5586 confuses me.
> 
> I bumped it to the same tools version as in the r5586 NaCl DEPS file.  That
> seemed to be the safest version, since it most closely matches NaCl's
> environment.

[Matt Ball, 2011-06-09 20:51:25]

Committed as r88578

On Thu, Jun 9, 2011 at 2:48 PM, <noelallen@google.com> wrote:

> LGTM
>
>
>
>
http://codereview.chromium.**org/7046079/diff/1/DEPS<http://codereview.chromi...
> File DEPS (right):
>
>
http://codereview.chromium.**org/7046079/diff/1/DEPS#**newcode15<http://coder...
> DEPS:15: "nacl_tools_revision": "5580",
> Sounds right to me.
>
>
> On 2011/06/09 20:11:33, Matt Ball wrote:
>
>> On 2011/06/09 20:06:33, Nick Bray wrote:
>> > You don't need to bump nacl_tools_revision, but it doesn't hurt.
>>
> Why you
>
>> didn't
>> > bump it to 5586 confuses me.
>>
>
>  I bumped it to the same tools version as in the r5586 NaCl DEPS file.
>>
> That
>
>> seemed to be the safest version, since it most closely matches NaCl's
>> environment.
>>
>
>
http://codereview.chromium.**org/7046079/<http://codereview.chromium.org/7046...
>