First steps towards better code generation for LBranch:

src/arm/full-codegen-arm.cc

Index: src/arm/full-codegen-arm.cc
===================================================================
--- src/arm/full-codegen-arm.cc	(revision 8228)
+++ src/arm/full-codegen-arm.cc	(working copy)
@@ -383,7 +383,7 @@
   // For simplicity we always test the accumulator register.
   codegen()->Move(result_register(), slot);
   codegen()->PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
-  codegen()->DoTest(true_label_, false_label_, fall_through_);
+  codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);

[Kevin Millikin (Chromium), 2011/06/10 09:35:06]

Hmmm, it might be useful to have a DoTest that takes a test context (and just
forwards to the one with explicit arguments) for simplicity.

[Sven Panne, 2011/06/14 08:04:48]

I think it even makes sense to have *only* such a DoTest. This has the advantage
that the fact will be very explicit that we use the value of the left operand
for *2* things: The value itself and for control.

 }
 
 
@@ -417,7 +417,7 @@
     if (true_label_ != fall_through_) __ b(true_label_);
   } else {
     __ LoadRoot(result_register(), index);
-    codegen()->DoTest(true_label_, false_label_, fall_through_);
+    codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);
   }
 }
 
@@ -464,7 +464,7 @@
   } else {
     // For simplicity we always test the accumulator register.
     __ mov(result_register(), Operand(lit));
-    codegen()->DoTest(true_label_, false_label_, fall_through_);
+    codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);
   }
 }
 
@@ -500,7 +500,7 @@
   __ Drop(count);
   __ Move(result_register(), reg);
   codegen()->PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
-  codegen()->DoTest(true_label_, false_label_, fall_through_);
+  codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);
 }
 
 
@@ -578,7 +578,8 @@
 }
 
 
-void FullCodeGenerator::DoTest(Label* if_true,
+void FullCodeGenerator::DoTest(Expression* condition,
+                               Label* if_true,
                                Label* if_false,
                                Label* fall_through) {
   if (CpuFeatures::IsSupported(VFP3)) {