First steps towards better code generation for LBranch:

src/full-codegen.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 423 matching lines @@
 
 void FullCodeGenerator::StackValueContext::Plug(Register reg) const {
   __ push(reg);
 }
 
 
 void FullCodeGenerator::TestContext::Plug(Register reg) const {
   // For simplicity we always test the accumulator register.
   __ Move(result_register(), reg);
   codegen()->PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
-  codegen()->DoTest(true_label_, false_label_, fall_through_);
+  codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);
 }
 
 
 void FullCodeGenerator::EffectContext::PlugTOS() const {
   __ Drop(1);
 }
 
 
 void FullCodeGenerator::AccumulatorValueContext::PlugTOS() const {
   __ pop(result_register());
 }
 
 
 void FullCodeGenerator::StackValueContext::PlugTOS() const {
 }
 
 
 void FullCodeGenerator::TestContext::PlugTOS() const {
   // For simplicity we always test the accumulator register.
   __ pop(result_register());
   codegen()->PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
-  codegen()->DoTest(true_label_, false_label_, fall_through_);
+  codegen()->DoTest(condition_, true_label_, false_label_, fall_through_);
 }
 
 
 void FullCodeGenerator::EffectContext::PrepareTest(
     Label* materialize_true,
     Label* materialize_false,
     Label** if_true,
     Label** if_false,
     Label** fall_through) const {
   // In an effect context, the true and the false case branch to the
@@ skipping 260 matching lines @@
     ForwardBailoutToChild(expr);
 
   } else if (context()->IsAccumulatorValue()) {
     VisitForAccumulatorValue(left);
     // We want the value in the accumulator for the test, and on the stack in
     // case we need it.
     __ push(result_register());
     Label discard, restore;
     PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
     if (is_logical_and) {
-      DoTest(&discard, &restore, &restore);
+      DoTest(expr, &discard, &restore, &restore);

[fschneider, 2011/06/10 09:18:18]

Shouldn't the test of the left subexpressions get the test ID left->test_id()?
It has to match what the Crankshaft graph builder is doing.

[Kevin Millikin (Chromium), 2011/06/10 09:35:06]

I think you could do it either way (as long as they agree), but Florian's
suggestions seems more straightforward.  Use the ID of the expression we're
testing.

[Sven Panne, 2011/06/14 08:04:48]

Done.

     } else {
-      DoTest(&restore, &discard, &restore);
+      DoTest(expr, &restore, &discard, &restore);
     }
     __ bind(&restore);
     __ pop(result_register());
     __ jmp(&done);
     __ bind(&discard);
     __ Drop(1);
     PrepareForBailoutForId(right_id, NO_REGISTERS);
 
   } else if (context()->IsStackValue()) {
     VisitForAccumulatorValue(left);
     // We want the value in the accumulator for the test, and on the stack in
     // case we need it.
     __ push(result_register());
     Label discard;
     PrepareForBailoutBeforeSplit(TOS_REG, false, NULL, NULL);
     if (is_logical_and) {
-      DoTest(&discard, &done, &discard);
+      DoTest(expr, &discard, &done, &discard);
     } else {
-      DoTest(&done, &discard, &discard);
+      DoTest(expr, &done, &discard, &discard);
     }
     __ bind(&discard);
     __ Drop(1);
     PrepareForBailoutForId(right_id, NO_REGISTERS);
 
   } else {
     ASSERT(context()->IsEffect());
     Label eval_right;
     if (is_logical_and) {
       VisitForControl(left, &eval_right, &done, &eval_right);
@@ skipping 511 matching lines @@
   __ Drop(stack_depth);
   __ PopTryHandler();
   return 0;
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal