Merge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org>

Source/WebKit/chromium/ChangeLog

+2011-06-08  Justin Novosad  <junov@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [Chromium] Crash when closing a tab with accelerated 2d canvas
+        https://bugs.webkit.org/show_bug.cgi?id=62324
+        In GraphicsContext3DInternal::setContextLostCallback we are passing a
+        non-refcounted ptr to a refcounted member. this can cause an access
+        violation after the destruction of GraphicsContext3D.  Upon destruction
+        a null callback is sent to setContextLostCallback, which is good
+        except that it gets placed in a non-null adapter object.  This fix
+        prevents the creation of the adapter when the callback is null, thus
+        preventing a later crash.
+
+        * src/GraphicsContext3DChromium.cpp:
+        (WebCore::GraphicsContextLostCallbackAdapter::create):
+
+2011-06-08  James Robinson  <jamesr@chromium.org>
+
+        Hopefully last change to features.gypi - set ENABLE_REGISTER_PROTOCOL_HANDLER based off of the the variable set
+        in chromium's common.gypi. Should green up the chromium linux tester on build.webkit.org.
+
+        * features.gypi:
+
+2011-06-08  James Robinson  <jamesr@chromium.org>
+
+        Set ENABLE_REGISTER_PROTOCOL_HANDLER=1 for chromium. I didn't mean to turn that off...
+
+        * features.gypi:
+
+2011-06-08  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Update the chromium-within-WebKit revision to r88481
+        https://bugs.webkit.org/show_bug.cgi?id=62353
+
+        * DEPS:
+
+2011-06-08  Sailesh Agrawal  <sail@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [Chromium] Add stubs to WebWidget
+        https://bugs.webkit.org/show_bug.cgi?id=62263
+
+        This change add stub implementations for all WebWidget functions. Having stub methods should make it easier to add new functions to the class without breaking Chromium.
+
+        * public/WebWidget.h:
+        (WebKit::WebWidget::close):
+        (WebKit::WebWidget::size):
+        (WebKit::WebWidget::resize):
+        (WebKit::WebWidget::animate):
+        (WebKit::WebWidget::layout):
+        (WebKit::WebWidget::paint):
+        (WebKit::WebWidget::composite):
+        (WebKit::WebWidget::themeChanged):
+        (WebKit::WebWidget::handleInputEvent):
+        (WebKit::WebWidget::mouseCaptureLost):
+        (WebKit::WebWidget::setFocus):
+        (WebKit::WebWidget::setComposition):
+        (WebKit::WebWidget::confirmComposition):
+        (WebKit::WebWidget::compositionRange):
+        (WebKit::WebWidget::textInputType):
+        (WebKit::WebWidget::caretOrSelectionBounds):
+        (WebKit::WebWidget::selectionRange):
+        (WebKit::WebWidget::caretOrSelectionRange):
+        (WebKit::WebWidget::setTextDirection):
+        (WebKit::WebWidget::isAcceleratedCompositingActive):
+
+2011-06-08  Tom Sepez  <tsepez@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Add new permission callbacks for mixed content blocking.
+        https://bugs.webkit.org/show_bug.cgi?id=61946
+
+        * public/WebPermissionClient.h:
+        (WebKit::WebPermissionClient::allowDisplayingInsecureContent):
+        (WebKit::WebPermissionClient::allowRunningInsecureContent):
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::allowDisplayingInsecureContent):
+        (WebKit::FrameLoaderClientImpl::allowRunningInsecureContent):
+        * src/FrameLoaderClientImpl.h:
+
+2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Added new entries for skia/third_party/glu.
+
+        * DEPS:
+
+2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Rolled DEPS.
+
+        * DEPS:
+
+2011-06-08  Ryan Sleevi  <rsleevi@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
+
+        Compiling Chromium port under GCC 4.6 produces warnings about nullptr
+        https://bugs.webkit.org/show_bug.cgi?id=62242
+
+        * WebKit.gyp:
+
+2011-06-08  Greg Simon  <gregsimon@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Control Indexeddb backends from LayoutTestController
+        https://bugs.webkit.org/show_bug.cgi?id=61000
+
+        * public/WebIDBFactory.h:
+        * src/AssertMatchingEnums.cpp:
+        * src/WebIDBFactoryImpl.cpp:
+        (WebKit::WebIDBFactory::setOverrideBackingStoreType):
+        (WebKit::WebIDBFactory::setTemporaryDatabaseFolder):
+        (WebKit::WebIDBFactoryImpl::open):
+
+2011-06-08  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Add a method to return the line breaks for any element with
+        multiline text content.
+        https://bugs.webkit.org/show_bug.cgi?id=62236
+
+        * public/WebAccessibilityObject.h:
+        * src/WebAccessibilityObject.cpp:
+        (WebKit::WebAccessibilityObject::lineBreaks):
+
+2011-06-08  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Unreviewed chromium build fix for r88332.
+
+        * src/WebRuntimeFeatures.cpp:
+
+2011-06-08  Hironori Bono  <hbono@chromium.org>
+
+        Reviewed by Brent Fulgham.
+
+        Add SpellCheck API
+        https://bugs.webkit.org/show_bug.cgi?id=59693
+
+        This change adds two SpellCheck API functions (addSpellcheckRange and
+        removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
+        the public-webapps ML. This change is currently available only on Chromium.
+
+        * features.gypi:
+        * public/WebRuntimeFeatures.h:
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+        * src/WebRuntimeFeatures.cpp:
+        (WebKit::WebRuntimeFeatures::enableSpellCheckAPI):
+        (WebKit::WebRuntimeFeatures::isSpellCheckAPIEnabled):
+
+2011-06-07  James Kozianski  <koz@chromium.org>
+
+        [Chromium] Unreviewed. Disable SelectItemEvenFire that fails on
+        chromium canaries.
+
+        * tests/PopupMenuTest.cpp:
+        (WebKit::TEST_F):
+
+2011-06-07  Robert Kroeger  <rjkroege@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [chromium] Add a basic gesture recognizer to the Chromium platform
+        https://bugs.webkit.org/show_bug.cgi?id=54417
+
+        Added unit tests for the basic chromium platform gesture recognizer.
+
+        * tests/InnerGestureRecognizerTest.cpp: Added.
+        (WebCore::InspectableInnerGestureRecognizer::InspectableInnerGestureRecognizer):
+        (WebCore::InspectableInnerGestureRecognizer::signature):
+        (WebCore::InspectableInnerGestureRecognizer::firstTouchPosition):
+        (WebCore::InspectableInnerGestureRecognizer::setFirstTouchTime):
+        (WebCore::InspectableInnerGestureRecognizer::firstTouchTime):
+        (WebCore::InspectableInnerGestureRecognizer::setLastTouchTime):
+        (WebCore::InspectableInnerGestureRecognizer::lastTouchTime):
+        (WebCore::InspectableInnerGestureRecognizer::edgeFunction):
+        (WebCore::InspectableInnerGestureRecognizer::updateValues):
+        (WebCore::InspectableInnerGestureRecognizer::addEdgeFunction):
+        (WebCore::BuildablePlatformTouchPoint::setX):
+        (WebCore::BuildablePlatformTouchPoint::setY):
+        (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
+        (WebCore::TestGestureRecognizer::TestGestureRecognizer):
+        (WebCore::TestGestureRecognizer::SetUp):
+        (WebCore::TestGestureRecognizer::TearDown):
+        (WebCore::TEST_F):
+
+2011-06-07  Vangelis Kokkevis  <vangelis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        Disable compositing for RTL pages in the RenderLayerCompositor rather
+        than later on in the WebViewImpl.
+        https://bugs.webkit.org/show_bug.cgi?id=62246
+
+        * src/ChromeClientImpl.cpp:
+        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::layout):
+        (WebKit::WebViewImpl::setRootGraphicsLayer):
+
+2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r88254, r88262, and r88268.
+        http://trac.webkit.org/changeset/88254
+        http://trac.webkit.org/changeset/88262
+        http://trac.webkit.org/changeset/88268
+        https://bugs.webkit.org/show_bug.cgi?id=62234
+
+        I fail at changing features.gypi (Requested by abarth on
+        #webkit).
+
+        * features.gypi:
+
+2011-06-07  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Tony Chang.
+
+        Fix "branding" issue in features.gypi
+        https://bugs.webkit.org/show_bug.cgi?id=62229
+
+        Apparently we need to move the conditional block further out of the
+        nesting in order to see the branding variable.  This patch also remove
+        the dummy branding variable I added to get the buildbot building again.
+
+        * features.gypi:
+
+2011-06-07  Adam Barth  <abarth@webkit.org>
+
+        Attempt to fix the cr-win build.
+
+        * features.gypi:
+
+2011-06-07  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
+        https://bugs.webkit.org/show_bug.cgi?id=62135
+
+        After this patch is rolled into Chromium, we should be able to delete
+        features_override.gyp downstream.  Once we do that, we can simplify
+        this file somewhat by removing at least on level of nesting.
+
+        * features.gypi:
+
+2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
+        https://bugs.webkit.org/show_bug.cgi?id=62019
+
+        Dispatch disconnecFrontend message in debugger task mode to make sure
+        it is processed even if execution is paused.
+
+        * src/WebWorkerImpl.cpp:
+        (WebKit::WebWorkerImpl::detachDevTools):
+        (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
+
+2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
+
+        Reviewed by Kent Tamura.
+
+        [Chromium] Click event is not fired for a menulist <select>
+        https://bugs.webkit.org/show_bug.cgi?id=60563
+
+        * tests/PopupMenuTest.cpp:
+        (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
+        (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
+        (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
+        (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
+        (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
+        (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
+        (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
+        (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
+        (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
+        (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
+        (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
+        * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
+        * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
+        * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
+        * WebKit.gyp: Added PopupMenuTest.cpp. Because webkit_support dependency is added, we can't build PopupMenuTest.cpp with Chromium-win (shared) configuration.
+
+2011-06-06  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make WebViewImpl's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62155
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/WebViewImpl.h:
+
+2011-06-06  Daniel Cheng  <dcheng@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        [chromium] Delete dead clipboard code.
+        https://bugs.webkit.org/show_bug.cgi?id=62113
+
+        * src/WebDragData.cpp:
+
+2011-06-06  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62148
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/WebURLRequest.cpp:
+        (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
+        * src/WebURLResponse.cpp:
+        (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
+
 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
 
         Reviewed by Tony Gentilcore.
 
         Add a "prerender" state for page visibility.
         https://bugs.webkit.org/show_bug.cgi?id=62062
 
         * public/WebPageVisibilityState.h:
         * src/AssertMatchingEnums.cpp:
         * src/WebViewImpl.cpp:
@@ skipping 7001 matching lines @@
         https://bugs.webkit.org/show_bug.cgi?id=53728
 
         * src/IDBCallbacksProxy.cpp:
         (WebCore::IDBCallbacksProxy::onBlocked):
         * src/IDBCallbacksProxy.h:
         * src/WebIDBCallbacksImpl.cpp:
         (WebCore::WebIDBCallbacksImpl::onBlocked):
         * src/WebIDBCallbacksImpl.h:
 
 == Rolled over to ChangeLog-2011-02-16 ==