DescriptionMerge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org>
Reviewed by James Robinson.
[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2011-06-08 Justin Novosad <junov@chromium.org>
Reviewed by James Robinson.
[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContextLostCallbackAdapter::create):
TBR=junov@chromium.org
BUG=85309
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88430
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|