Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 7046071: Merge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org> (Closed)

Created:
9 years, 6 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org>; Reviewed by James Robinson. [Chromium] Crash when closing a tab with accelerated 2d canvas https://bugs.webkit.org/show_bug.cgi?id=62324 Upon graphics context destruction, it is important to signal skia to abandon all of its resource handles. This prevents a crash caused by skia attempting to release resources that were in the destroyed graphics context. * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): 2011-06-08 Justin Novosad <junov@chromium.org>; Reviewed by James Robinson. [Chromium] Crash when closing a tab with accelerated 2d canvas https://bugs.webkit.org/show_bug.cgi?id=62324 In GraphicsContext3DInternal::setContextLostCallback we are passing a non-refcounted ptr to a refcounted member. this can cause an access violation after the destruction of GraphicsContext3D. Upon destruction a null callback is sent to setContextLostCallback, which is good except that it gets placed in a non-null adapter object. This fix prevents the creation of the adapter when the callback is null, thus preventing a later crash. * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::create): TBR=junov@chromium.org BUG=85309 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -2 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +236 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +330 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years, 6 months ago (2011-06-09 06:46:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698