Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 7046069: Copy chromeos_input_method* from libcros as-is. (Closed)

Created:
9 years, 6 months ago by satorux1
Modified:
9 years, 6 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Copy chromeos_input_method* from libcros as-is. We'll be modifying these files so we can use the code from Chrome without going through libcros. Before doing that, we check in the code as-is, so we can track diffs. % cp ~/chromeos/src/platform/cros/chromeos_input_method.cc ibus_controller.cc % cp ~/chromeos/src/platform/cros/chromeos_input_method.h ibus_controller.h % cp ~/chromeos/src/platform/cros/chromeos_input_method_unittest.cc ibus_controller_unittest.cc TEST=none (the code is unused now) BUG=chromium-os:16238 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1606 lines, -0 lines) Patch
A chrome/browser/chromeos/input_method/ibus_controller.h View 1 chunk +322 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/ibus_controller.cc View 1 chunk +1217 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/ibus_controller_unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
9 years, 6 months ago (2011-06-09 05:12:01 UTC) #1
Zachary Kuznia
9 years, 6 months ago (2011-06-09 05:27:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698