Issue 7046067: [Sync] Fix use of ObserverList by multiple threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046067: [Sync] Fix use of ObserverList by multiple threads. (Closed)

Created:
9 years, 6 months ago by akalin

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Fix use of ObserverList by multiple threads. This doesn't solve the underlying problem (see crbug.com/85481) but will enable re-landing 88151 for crbug.com/85296. BUG=82279 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88483

Patch Set 1 #

Patch Set 2 : sync to head #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -23 lines)			Patch
M	chrome/browser/sync/syncable/syncable.h	View		3 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View		5 chunks	+42 lines, -11 lines	0 comments	Download
M	tools/valgrind/tsan/suppressions.txt	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM, but it will conflict with my patch, so please wait till it lands :-)

9 years, 6 months ago (2011-06-09 00:53:06 UTC) #2

Change committed as 88483

Expand Messages | Collapse Messages