Allow dev context menu commands on chrome:// URLs.

Allow dev context menu commands on chrome:// URLs.
Previously, these commands were disabled on about: pages.
r88367 unified about: & chrome: and blocked WebUI dev commands.

BUG=55771
TEST="Inspect element", etc. available on chrome:// URLs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88498

[msw, 2011-06-08 23:32:22]

PTAL.

[Evan Stade, 2011-06-08 23:53:37]

lgtm

-- Evan Stade



On Wed, Jun 8, 2011 at 4:32 PM,  <msw@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Message:
> PTAL.
>
> Description:
> Allow dev context menu commands on chrome:// URLs.
> Previously, these commands were disabled on about: pages.
> r88367 unified about: & chrome: and blocked WebUI dev commands.
>
> BUG=55771
> TEST="Inspect element", etc. available on chrome:// URLs.
>
> Please review this at http://codereview.chromium.org/7046065/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/tab_contents/render_view_context_menu.cc
>
>
> Index: chrome/browser/tab_contents/render_view_context_menu.cc
> diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc
> b/chrome/browser/tab_contents/render_view_context_menu.cc
> index
>
71aa90960e0266aabc5e26d8d426dbc4270735df..dee54bfe5d7e5ce43c51ec5c6429060ed1a540da
> 100644
> --- a/chrome/browser/tab_contents/render_view_context_menu.cc
> +++ b/chrome/browser/tab_contents/render_view_context_menu.cc
> @@ -1588,11 +1588,6 @@ bool RenderViewContextMenu::IsDevCommandEnabled(int
> id) const {
>   if (active_entry->IsViewSourceMode())
>     return false;
>
> -  // Do not inspect Chrome URLs (chrome://network/, chrome://memory/,
> etc.).
> -  // However, do inspect about:blank, which is often used by ordinary web
> pages.
> -  if (active_entry->virtual_url().SchemeIs(chrome::kChromeUIScheme))
> -    return false;
> -
>   if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT) {
>     // Don't enable the web inspector if JavaScript is disabled.
>     if (!profile_->GetPrefs()->GetBoolean(prefs::kWebKitJavascriptEnabled)
> ||
>
>
>