chrome/browser/prerender/prerender_manager.cc - Issue 7046053: Add PrerenderUnload browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 7046053: Add PrerenderUnload browser test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add browser test Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index 09795894aefbc7fa3ed67c45926a1e725b42ddae..116e8d2636e2c55124d9b3e2ca816eddc8e7cdfe 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -80,7 +80,9 @@ class PrerenderManager::OnCloseTabContentsDeleter : public TabContentsDelegate {

}

virtual void CloseContents(TabContents* source) OVERRIDE {

- manager_->ScheduleDeleteOldTabContents(tab_.release(), this);

+ TabContentsWrapper* tab = tab_.release();

+ tab->tab_contents()->set_delegate(NULL);

+ manager_->ScheduleDeleteOldTabContents(tab, this);

mmenke 2011/06/08 22:29:05 nit: Any reason for not just doing: tab_->tab_co

cbentzel 2011/06/09 00:49:49 Nope. Changed to save one vertical line.

}

virtual bool ShouldSuppressDialogs() OVERRIDE {